-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ES solver #48
Fix ES solver #48
Conversation
Move output routine to base
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
========================================
+ Coverage 78.9% 84.7% +5.8%
========================================
Files 12 12
Lines 801 881 +80
========================================
+ Hits 632 747 +115
+ Misses 169 134 -35
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@streeve 'ES_Field_Solver' should really be 'ES_Field_Solver_1D' in its current form. Let me fix that. |
@streeve It looks like the CI is trying to test ES not in 1D (which it should only test in 1D). Do you know how the CI works and fix this? Thanks. |
@streeve It looks like the custom_init test was broken. I just fixed it and pushed to your fixup_es branch. |
Also adds to CI