Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES solver #48

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Fix ES solver #48

merged 6 commits into from
Mar 28, 2023

Conversation

streeve
Copy link
Member

@streeve streeve commented Feb 24, 2023

Also adds to CI

Move output routine to base
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #48 (09f97ec) into master (3d22919) will increase coverage by 5.8%.
The diff coverage is 93.1%.

@@           Coverage Diff            @@
##           master     #48     +/-   ##
========================================
+ Coverage    78.9%   84.7%   +5.8%     
========================================
  Files          12      12             
  Lines         801     881     +80     
========================================
+ Hits          632     747    +115     
+ Misses        169     134     -35     
Impacted Files Coverage Δ
example/example.cpp 93.5% <60.0%> (-1.7%) ⬇️
decks/custom_init.cxx 100.0% <100.0%> (+67.9%) ⬆️
src/fields.h 98.3% <100.0%> (+1.0%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@guangyechen
Copy link
Collaborator

@streeve 'ES_Field_Solver' should really be 'ES_Field_Solver_1D' in its current form. Let me fix that.

@guangyechen
Copy link
Collaborator

@streeve It looks like the CI is trying to test ES not in 1D (which it should only test in 1D). Do you know how the CI works and fix this? Thanks.

@guangyechen
Copy link
Collaborator

guangyechen commented Mar 24, 2023

@streeve It looks like the custom_init test was broken. I just fixed it and pushed to your fixup_es branch.

@guangyechen guangyechen merged commit f556411 into ECP-copa:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants