Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently in-use outfitting/1 and shipyard/1 schemas were designed before the Companion API was (semi-)supported by FDev, and the commodities/2 schema was designed for apps which obtained data via OCR. Therefore all three schemas were designed to transmit information using English-language text.
This has the side-effect that sending apps such as EDMC have been forced into the role of gatekeepers of the Companion API data; until the authors of the sending apps have figured out the correct "translation" of a token from the Companion API into English then the apps send information incorrectly or not at all. The authors of the sending apps are not necessarily best placed to figure out this "translation" since they only see a small subset of the available data.
This PR:
Introduces new simplified schemas for outfitting and shipyard that send the FDev symbolic names from the Companion API directly instead of sending English names, classes and ratings. Here is a sample outfitting message in the new schema.
Introduces a new schema for commodities that sends commodity names as they appear in the FDev Companion API instead of sending English names, and reports additional useful info:
Here is an example of a message in the new schema which illustrates this new info.
Undoes PR Add FDev IDs - two proposals #42 including the sending of FDev integer IDs - I believe that the FDev symbolic names are more useful and, unlike numeric IDs, they are exposed in the forthcoming Journal.
Implications for senders:
Implications for listeners: