Cleanup of EDMarketConnector.py #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed a couple of E501 ignores tagged as now un-necessary.
* docstring indent on Class A. * Minor white space adjustments.
This smells of something added for debugging that can be better done under a proper debugging setup.
This allows the type to be known, but leaves the proper setting of the value until later (after UI creation).
* Ignore Tkinter 'name' complaints. I've opened <python/typeshed#4658> to get this fixed in typeshed. * If checking `import update` so it's available. * Don't annotate journal_event 'event' arg, as it's passed through Tk events mechanism, so let mypy infer it.
Some of our code is just cognitively complex.
* retry_for_shipyard() was only called by itself (for further retry), and tried to call self.eddn.export_shipyard() which doesn't even exist. I suspect this has been unused code since the EDDN code was extracted out into an internal plugin. * self.drag_offset given proper typing. * All functions have at least some typing now. Left the 'event' Tk arguments bare as mypy seems to infer without complaint.
And added `# type: ignore` comments. This is a mess. On the tkinter side it *is* an int, default 0. But enough python stuff has assumed it's a bool for typeshed to define that tearoff should be. It doesn't match, mypy complains.
* journal_event() annotate the noqa complexity comment. * dashboard_event() convert to 'bail early' to save indentiation.
A-UNDERSCORE-D
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim here is to get it passing my pre-commit hooks, so flake8 and mypy primarily.
I'm leaving TODO's behind on some things for later cleanup.