-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed 3D Map enhancements #39
Comments
Great points. But we might need to change render engine to get everything I can give you write access to the repository to if you wants. 2015-12-29 17:03 GMT+01:00 Greg Malcolm notifications@github.com:
|
Thanks, sounds good! Although if you don't mind I'd still be inclined to put most of my changes through as Pull Requests just so it gets some peer review. I just took a glance at how you're rendering the map. OpenGL right? Should be pretty powerful... :D |
I add you to the group. So you can make smaller changes directly. And a branch for bigger test changes. 2015-12-29 17:20 GMT+01:00 Greg Malcolm notifications@github.com:
|
Yes openGL ashould be enough, Just unsure if the .net wrapper i am using Its pretty fast to draw all points now atleast. 2015-12-29 17:27 GMT+01:00 Robert Wahlström robert.l.wahlstrom@gmail.com:
|
Ah. well we could always extend the wrapper if we have to if it's "open"... :D |
I like all your suggestions. The only real issue with the map is that it doesn't rotate and move around like the in-game one. It disorients me and makes my eyes "pop" to see the Galaxy "inverse" to what it should be, while I don't get that in game. (As in, the Thargoid bubble will be "towards me" and then when I rotate the map a little, it will suddenly "pop" and look like it is far from me. Hard to explain but it's a visual effect thing) Mark Mark Jelic
|
Yep, that's exactly the kind of thing area I want to improve on. I'd like rotation and translation to mimic the game control style to some degree. |
I just started experimenting in the grid. Need to adapt it too zoom level and decide a good standard color. |
I actually tweaked that a little in my latest PR. Apologies if my change has messed up what you're working on. It got pretty involved... :D The color I switched it to was taken by doing a screen grab from Elite Dangerous. I also tweaked the background color a little the same way. Still looks kind of black, but less absolute black, which is a little less surprising to the eye. |
Go ahead and work on it. I will concentrate my work in some other areas for 2016-01-01 7:02 GMT+01:00 Greg Malcolm notifications@github.com:
|
Prospecting module would be very welcome! Only place to put that info now is in the Notes. Btw, another thing I think would be interesting to track, for us explorers, is a checkbox indicating we were the first to discover that system or the first star or even just a planet. Check it on if you discovered it first. Leave it off, otherwise. Mark Mark Jelic
|
Yes we should add a such button soon. On the 3dMaps. Your new grid color looks good. 2016-01-01 11:06 GMT+01:00 Mark notifications@github.com:
|
I was thinking it would be useful to see the exact cursor positions on Another thought for the Future: encapsulate map in a User Control. Then
|
Just updated the list of things to do. I've changed quite a few to an updated opinion of what needs doing for quite a few of them. |
As long as the 3D map works like the in-game on, as much as possible, I'll be happy. (In terms of using the mouse to rotate and translate and zoom in and out.) |
re points 15 and 17 - I added the default centre because I want it it to open centred on the same place every time whatever I've got selected in the Travel History - just not Sol... Noticed it opening on the selected system last night and thought there was a bug before I noticed it had been introduced deliberately. So, rather than just "fixing" it back to the way I want it, I'm thinking I could add a setting that controls whether the map opens on the default centre system or the selected system (possibly extending 'selected system' so that if the grid selection doesn't have coordinates it looks for the nearest one - by number of jumps since we don't have coordinates so can't get an actual distance - in the the travel history that does have rather than it defaulting to Sol where the selected system has no coordinates) and a toggle on the map dialog to switch quickly between default centre and travel history selection. The new setting could go on the settings tab and the setting of the default centre moved there at the same time. Anyone object to that? |
What you're suggesting sounds fine to me. Btw, I had a go at the latest build that's available to download and the 3D map is coming along very well! I did have a problem when I tried to move the centre of the rotation by using the two button mouse drag or even just the right mouse button drag. It basically messed the location up and had to close and re-open to fix it. Mark
|
@iainross: Only just noticed your comment. It's good, thanks! I've had some thoughts on default Zoom levels, but I'll break it off into another issue. |
Closed. 3dmap has moved on a lot since this. Please open a new issue if you have any more comments |
There are number of little enhancements I'd love to work on for the 3D map. I thought I'd list them to see if there's is any objection. The plan is to hit each small item as a separate pull request so that there's the opportunity to reject or request change individually. Also if we end up working on the same area at once it's easier to just throw away the proposed change and say "oh well!".
3D Map:
Keyboard controls: I'd like cursor keys and ASWD for translating the map up down left and right. + and - for zoom.DONE!Would be nice if there was a toggleable grid. Perhaps something in line with the in-game gridLooks like something along these lines is already in place. Although may still be fun to see if it can be improved on.position should also be labelled. Maybe zooming in causes more labeling detail.
3D Map should center on the system selected before clicking on "3D Map". This should also be the default "Center" textbox entry- Thanks @iainrossDefault button is becoming less relevant. Banish it to the settings page at some point?- Thanks @iainrossSome of the items near the end of the list are moving from "quick change" to "challenging, may not happen". But listing them because why not?
The text was updated successfully, but these errors were encountered: