-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image #16
Fix image #16
Conversation
Sync with EDYO/master branch
Merge from last changes
Regarding the code, it is only checking the file exists... not sure if that's much useful than having an exception being raised. If that's ok, it's ok to me. |
IMHO is more "elegant" raise an Error instead of a ffmpeg syscall exception. |
Might be more elegant, but it's more processing overhead, not providing anything different, and making debugging harder. I would wait to have appu more mature and used before making it elegant, but, as I already said, if that's ok to you, it's ok to me :) What I think must be fixed is the amount of commits in this PR. I would suggest to rebase them all squashing on one single one, and then |
BTW, sorry for being unclear in my review, and for bringing this back again |
Excellent articles and documentation. I didn't know it (referring to EAFP ). I'll adapt the code following this filosophy and I'll have in mind for future developments. |
If you set an incorrect file name to use it as a cover image, appu execution fails at the end. I set a check with a more descriptive error at the beginning of the process. Fixes #14