-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Python 3 and all the basic libraries #18
Conversation
The changes in code are to support Python 3. I've tested appu keeps working after all the upgrades.
sudo: required | ||
language: python | ||
python: | ||
- "3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No legit reason, just this is my current Python version. Strong preference for 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oky, but we can use tools like pyenv to manage this.
This allows to have two different sets of requirements to install. The production requirements are only needed for environments where we'll just run appu, not development or testing environments. The development requirements file includes the production one so the dependencies locked are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the requirements.txt, probably we can use pipenv directly.
sudo: required | ||
language: python | ||
python: | ||
- "3.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oky, but we can use tools like pyenv to manage this.
This also updates CI configuration, which should still work.