-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update known issue about lmod hook in host-injection #183
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
70004f9
Update known issue about lmod hook in host-injection
xinan1911 afb7c24
Update mkdocs.yml for structure and remove version pages of known issues
xinan1911 eb02210
Adding reference to Lmod hooks
xinan1911 0b6c2e8
Update docs/known_issues/eessi-2023.06.md
xinan1911 1adfa66
Merge pull request #214 from EESSI/main
xinan1911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these are two seperate issues, right? I mean #456 was about site-specific tuning in general, but it only became an 'issue' when people hit the Failed-to-modify error. Shouldn't we just add to the "Failed to modify UD QP to INIT... etc" that the OMPI_MCA_* environment variables can be done in
host_injections/...
?I was browsing the docs, I think we should have some general explaination of
host_injections
underAdvanced usage
. I.e. that this directory is used for site specific tuning. And then, in a paragraph there, we can add how it can be used to execute LMOD hooks for site specific tuning. We can give an example there of a hook (might as well use the example of setting these three OpenMPI environment variables). It's a good point, I wanted to make this documentation, but didn't get to it before my leave. Writing it as a todo for this afternoon... We can then refer to that from the "Failed to modify UD QP to INIT" known issue and give the code for the LMOD hook that can be used as a workaround for this particular issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs PR for Lmod hooks made here. I'd simply put an example hook to resolve this issue under the existing
Failed to modify UD QP to INIT on mlx5_0: Operation not permitted
header, and reference the new docs on Lmod hooks for further information.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@casparvl Adjusted on the known issues pages. Could you review it and if everything is okay, merge it?