Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to run test suite at the end of a build job #222

Merged
merged 12 commits into from
Nov 26, 2023

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Oct 13, 2023

  • Adds the necessary steps to the Slurm job script.
  • Adds handling of the result of the test suite run (i.e., updating the PR comment).
  • Adds one config setting job_test_unknown_fmt and corresponding description.

Also see accompanying PR for software-layer EESSI/software-layer#366

edit (by @boegel): it's worth noting that these changes will require adding job_test_unknown_fmt to the bot configuration file, or the job manager will crash with:

...
  File "/home/boegel/eessi-bot-software-layer/eessi_bot_job_manager.py", line 572, in process_finished_job
    job_test_unknown_fmt = finished_job_comments_cfg[JOB_TEST_UNKNOWN_FMT]
  File "/usr/lib64/python3.6/configparser.py", line 1233, in __getitem__
    raise KeyError(key)
KeyError: 'job_test_unknown_fmt'

when processing a finished job

@trz42 trz42 added the feature label Oct 13, 2023
scripts/bot-build.slurm Outdated Show resolved Hide resolved
eessi_bot_job_manager.py Outdated Show resolved Hide resolved
boegel and others added 2 commits November 26, 2023 12:25
@boegel
Copy link
Contributor

boegel commented Nov 26, 2023

testing this via boegel/software-layer#30 ...

app.cfg.example Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
eessi_bot_job_manager.py Outdated Show resolved Hide resolved
@boegel
Copy link
Contributor

boegel commented Nov 26, 2023

Extensively tested via boegel/software-layer#30, good to merge, thanks @trz42!

@boegel boegel merged commit 28b7b85 into EESSI:develop Nov 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants