Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494

casparvl · 2024-03-09T12:33:02Z

301ab59 prevents deploying software for which the PR in EasyBuild is still open. In principle, that's good, but it would lead to failures in the EESSI PR which are unclear to the end user, e.g. as in #479 (comment) . In these failing cases, the only thing you see is the status is failure, and the details reflect that ERROR: was found, as well as a non-zero excit code on check_missing_installations.

This is quite unspecific if the only issue is an umerged PR. It should be clear to the end user that the build succeeded, that all the software ended up in the tarball, but the only issue is an unmerged PR.

In this PR, I use inspiration from @ocaisa 's #493 . He made it possible to make an exception for --from-pr statements that are added in the software-layer PR that tries to add software. In this PR, I use that conditionally:

First, we check for missing installations as was implemented in 301ab59 . I.e. we check using the EasyConfigs from develop. If there is an unmerged EasyBuild PR, this will fail.
Upon failure, I use @ocaisa 's logic to run the same check, but now with an exceptions for the --from-pr statements added in the software-layer PR. If that does pass, it is clear that some of the EasyBuild PR's referred to in this software-layer PR are not merged yet. We can then print a clear message in the output file.
The final step is that in the check-build.sh, I pick up on this pattern. if it is present, I add a reason for the failure.

Note that I also refactored the check-build.sh a bit. The definition and useage of certain variables was far apart, making it hard to trace what was happening. I've refactored that so that things are defined and used 'in order', which makes it easier to understand what is happening in the code.

…only for items added to the EasyStack file in _this_ PR to software-layer. If that succeeds, the reason must be that one of the EasyBuild PRs wasn't merged yet, and we can add that information to the fail_msg to make it more explicit

…e printed on a build failure here

eessi-bot-aws · 2024-03-09T12:33:06Z

Instance eessi-bot-mc-aws is configured to build:

arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
arch x86_64/generic for repo eessi-hpc.org-2023.06-software
arch x86_64/generic for repo eessi.io-2023.06-compat
arch x86_64/generic for repo eessi.io-2023.06-software
arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
arch x86_64/intel/haswell for repo eessi.io-2023.06-software
arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
arch aarch64/generic for repo eessi-hpc.org-2023.06-software
arch aarch64/generic for repo eessi.io-2023.06-compat
arch aarch64/generic for repo eessi.io-2023.06-software
arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

casparvl · 2024-03-09T12:35:29Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-09T12:35:32Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from casparvl
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3
handling command build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3 resulted in:
- submitted job 7358, for details & status see Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494 (comment)

eessi-bot-aws · 2024-03-09T12:35:36Z

New job on instance eessi-bot-mc-aws for architecture x86_64-amd-zen3 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.03/pr_494/7358

date	job status	comment
Mar 09 12:35:35 UTC 2024	submitted	job id `7358` awaits release by job manager
Mar 09 12:36:00 UTC 2024	released	job awaits launch by Slurm scheduler
Mar 09 12:40:04 UTC 2024	running	job `7358` is running
Mar 09 12:42:08 UTC 2024	finished	😁 SUCCESS (click triangle for details) Details ✅ job output file `slurm-7358.out` ✅ no message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ✅ found message(s) matching `No missing installations` ✅ found message matching `.tar.gz created!` Artefacts `eessi-2023.06-software-linux-x86_64-amd-zen3-1709988091.tar.gz` size: 1 MiB (1782658 bytes) entries: 37 modules under 2023.06/software/linux/x86_64/amd/zen3/modules/all `CFITSIO/4.3.1-GCCcore-13.2.0.lua` software under 2023.06/software/linux/x86_64/amd/zen3/software `CFITSIO/4.3.1-GCCcore-13.2.0` other under 2023.06/software/linux/x86_64/amd/zen3 `.lmod/cache/spiderT.lua` `.lmod/cache/spiderT.luac_5.1` `.lmod/cache/timestamp`
Mar 09 12:42:08 UTC 2024	test result	(no tests yet)

casparvl · 2024-03-09T12:37:23Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-09T12:37:26Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from casparvl
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3
handling command build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3 resulted in:
- submitted job 7359, for details & status see Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494 (comment)

eessi-bot-aws · 2024-03-09T12:37:29Z

New job on instance eessi-bot-mc-aws for architecture x86_64-amd-zen3 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.03/pr_494/7359

date	job status	comment
Mar 09 12:37:28 UTC 2024	submitted	job id `7359` awaits release by job manager
Mar 09 12:38:02 UTC 2024	released	job awaits launch by Slurm scheduler
Mar 09 12:42:07 UTC 2024	running	job `7359` is running
Mar 09 12:44:10 UTC 2024	finished	😢 FAILURE (click triangle for details) Details ✅ job output file `slurm-7359.out` ❌ found message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ❌ no message matching `No missing installations` ✅ found message matching `.tar.gz created!` Artefacts `eessi-2023.06-software-linux-x86_64-amd-zen3-1709988194.tar.gz` size: 1 MiB (1783920 bytes) entries: 37 modules under 2023.06/software/linux/x86_64/amd/zen3/modules/all `CFITSIO/4.3.1-GCCcore-13.2.0.lua` software under 2023.06/software/linux/x86_64/amd/zen3/software `CFITSIO/4.3.1-GCCcore-13.2.0` other under 2023.06/software/linux/x86_64/amd/zen3 `.lmod/cache/spiderT.lua` `.lmod/cache/spiderT.luac_5.1` `.lmod/cache/timestamp`
Mar 09 12:44:10 UTC 2024	test result	(no tests yet)

casparvl · 2024-03-09T12:54:24Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-09T12:54:26Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from casparvl
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3
handling command build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3 resulted in:
- submitted job 7360, for details & status see Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494 (comment)

eessi-bot-aws · 2024-03-09T12:54:30Z

New job on instance eessi-bot-mc-aws for architecture x86_64-amd-zen3 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.03/pr_494/7360

date	job status	comment
Mar 09 12:54:29 UTC 2024	submitted	job id `7360` awaits release by job manager
Mar 09 12:55:14 UTC 2024	released	job awaits launch by Slurm scheduler
Mar 09 12:56:15 UTC 2024	running	job `7360` is running
Mar 09 12:57:16 UTC 2024	finished	😢 FAILURE (click triangle for details) Details ✅ job output file `slurm-7360.out` ❌ found message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ✅ found message(s) matching `No missing installations` ✅ found message matching `.tar.gz created!` Artefacts `eessi-2023.06-software-linux-x86_64-amd-zen3-1709989018.tar.gz` size: 1 MiB (1782090 bytes) entries: 37 modules under 2023.06/software/linux/x86_64/amd/zen3/modules/all `CFITSIO/4.3.1-GCCcore-13.2.0.lua` software under 2023.06/software/linux/x86_64/amd/zen3/software `CFITSIO/4.3.1-GCCcore-13.2.0` other under 2023.06/software/linux/x86_64/amd/zen3 `.lmod/cache/spiderT.lua` `.lmod/cache/spiderT.luac_5.1` `.lmod/cache/timestamp`
Mar 09 12:57:16 UTC 2024	test result	(no tests yet)

casparvl · 2024-03-09T13:08:46Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-09T13:08:49Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from casparvl
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3
handling command build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3 resulted in:
- submitted job 7361, for details & status see Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494 (comment)

eessi-bot-aws · 2024-03-09T13:08:52Z

New job on instance eessi-bot-mc-aws for architecture x86_64-amd-zen3 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.03/pr_494/7361

date	job status	comment
Mar 09 13:08:52 UTC 2024	submitted	job id `7361` awaits release by job manager
Mar 09 13:09:20 UTC 2024	released	job awaits launch by Slurm scheduler
Mar 09 13:10:22 UTC 2024	running	job `7361` is running
Mar 09 13:11:23 UTC 2024	finished	😢 FAILURE (click triangle for details) Reason EasyConfig not found during missing installation check. Are you sure all PRs referenced have been merged in EasyBuild? Details ✅ job output file `slurm-7361.out` ❌ found message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ❌ no message matching `No missing installations` ✅ found message matching `.tar.gz created!` Artefacts `eessi-2023.06-software-linux-x86_64-amd-zen3-1709989862.tar.gz` size: 1 MiB (1782796 bytes) entries: 37 modules under 2023.06/software/linux/x86_64/amd/zen3/modules/all `CFITSIO/4.3.1-GCCcore-13.2.0.lua` software under 2023.06/software/linux/x86_64/amd/zen3/software `CFITSIO/4.3.1-GCCcore-13.2.0` other under 2023.06/software/linux/x86_64/amd/zen3 `.lmod/cache/spiderT.lua` `.lmod/cache/spiderT.luac_5.1` `.lmod/cache/timestamp`
Mar 09 13:11:23 UTC 2024	test result	(no tests yet)

bot/check-build.sh

check_missing_installations.sh

Co-authored-by: ocaisa <alan.ocais@cecam.org>

…nt in running the eb --missing again in that case, since there were no --from-pr's in this PR to begin with, so unmerged PRs cannot be the reason for failing

…ftware-layer into improve_error_on_unmerged_pr

ocaisa · 2024-03-12T14:53:16Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-12T14:53:18Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from ocaisa
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3

eessi-bot-aws · 2024-03-12T14:53:22Z

error: patch failed: easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml:10 error: easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml: patch does not apply Unable to download or merge changes between the source branch and the destination branch.Tip: This can usually be resolved by syncing your branch and resolving any merge conflicts.

…ed_pr

ocaisa · 2024-03-13T14:24:48Z

bot: build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3

eessi-bot-aws · 2024-03-13T14:24:51Z

Updates by the bot instance eessi-bot-mc-aws (click for details)

received bot command build repo:eessi.io-2023.06-software arch:x86_64/amd/zen3 from ocaisa
- expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3
handling command build repository:eessi.io-2023.06-software architecture:x86_64/amd/zen3 resulted in:
- submitted job 8072, for details & status see Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494 (comment)

eessi-bot-aws · 2024-03-13T14:24:55Z

New job on instance eessi-bot-mc-aws for architecture x86_64-amd-zen3 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.03/pr_494/8072

date	job status	comment
Mar 13 14:24:54 UTC 2024	submitted	job id `8072` awaits release by job manager
Mar 13 14:25:33 UTC 2024	released	job awaits launch by Slurm scheduler
Mar 13 14:29:35 UTC 2024	running	job `8072` is running
Mar 13 14:31:41 UTC 2024	finished	😁 SUCCESS (click triangle for details) Details ✅ job output file `slurm-8072.out` ✅ no message matching `ERROR:` ✅ no message matching `FAILED:` ✅ no message matching `required modules missing:` ✅ found message(s) matching `No missing installations` ✅ found message matching `.tar.gz created!` Artefacts `eessi-2023.06-software-linux-x86_64-amd-zen3-1710340263.tar.gz` size: 0 MiB (204689 bytes) entries: 3 modules under 2023.06/software/linux/x86_64/amd/zen3/modules/all no module files in tarball software under 2023.06/software/linux/x86_64/amd/zen3/software no software packages in tarball other under 2023.06/software/linux/x86_64/amd/zen3 `.lmod/cache/spiderT.lua` `.lmod/cache/spiderT.luac_5.1` `.lmod/cache/timestamp`
Mar 13 14:31:41 UTC 2024	test result	(no tests yet)

ocaisa · 2024-03-13T14:27:28Z

easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml

+  - CFITSIO-4.3.1-GCCcore-13.2.0.eb:
+      options:
+        from-pr: 19840


Assuming this needs to be removed before we consider merging

easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml

check_missing_installations.sh

bot/check-build.sh

Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>

ocaisa · 2024-03-13T16:14:29Z

@casparvl Do you think there is something wrong with this as merged? We were planning to test it via #499 but it is not actually commenting in the tests (see #499 (comment) for example)

ocaisa and others added 5 commits March 8, 2024 17:30

Allow for open PRs when checking missing installations in build script

45022b6

Check for unmerged EasyConfig output pattern

723fce8

Merge branch 'tweak_missing_installs' into improve_error_on_unmerged_pr

5cd559e

Add CFITSIO as a test example, see if we can get a clear error messag…

b789108

…e printed on a build failure here

Added clarifying comment

d178a8f

Correct mistake: I meant to _move_ the awk part, not duplicate it

9123c9c

casparvl mentioned this pull request Mar 9, 2024

Allow for open PRs when checking missing installations in build script #493

Closed

Now actually check against the exit code of the pipe...

7e44223

Make seperate exit code for the run that allows --from-pr

da749a1

ocaisa reviewed Mar 11, 2024

View reviewed changes

bot/check-build.sh Outdated Show resolved Hide resolved

ocaisa reviewed Mar 11, 2024

View reviewed changes

check_missing_installations.sh Outdated Show resolved Hide resolved

casparvl and others added 3 commits March 11, 2024 15:59

Correct typo

a8c2883

Co-authored-by: ocaisa <alan.ocais@cecam.org>

Skip the if-condition also if pr_exceptions is empty. There is no poi…

6553e29

…nt in running the eb --missing again in that case, since there were no --from-pr's in this PR to begin with, so unmerged PRs cannot be the reason for failing

Merge branch 'improve_error_on_unmerged_pr' of github.com:casparvl/so…

8990e37

…ftware-layer into improve_error_on_unmerged_pr

casparvl mentioned this pull request Mar 11, 2024

{2023.06}[foss/2023b] WSClean 3.4 + DP3 6.0 #479

Merged

Merge branch '2023.06-software.eessi.io' into improve_error_on_unmerg…

b52db4b

…ed_pr

ocaisa reviewed Mar 13, 2024

View reviewed changes

boegel requested changes Mar 13, 2024

View reviewed changes

easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023b.yml Outdated Show resolved Hide resolved

boegel requested changes Mar 13, 2024

View reviewed changes

check_missing_installations.sh Outdated Show resolved Hide resolved

bot/check-build.sh Outdated Show resolved Hide resolved

ocaisa and others added 3 commits March 13, 2024 15:46

Update bot/check-build.sh

c08831e

Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>

Remove PR to trigger comment

992b11d

Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>

Trigger on any non-zero exit code

8d6493e

Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>

boegel changed the title ~~Improve error on unmerged pr~~ Improve error reported by bot when using unmerged EasyBuild PR in easystack file Mar 13, 2024

boegel approved these changes Mar 13, 2024

View reviewed changes

boegel merged commit 1dee560 into EESSI:2023.06-software.eessi.io Mar 13, 2024
34 checks passed

boegel mentioned this pull request Mar 14, 2024

{2023.06}[foss/2023b] GROMACS 2024.1 #499

Merged

boegel added the 2023.06-software.eessi.io 2023.06 version of software.eessi.io label Mar 15, 2024

boegel mentioned this pull request Mar 15, 2024

fix check_missing_installations.sh when unmerged PR is used #506

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494

Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

ocaisa commented Mar 12, 2024

eessi-bot-aws bot commented Mar 12, 2024

eessi-bot-aws bot commented Mar 12, 2024

ocaisa commented Mar 13, 2024

eessi-bot-aws bot commented Mar 13, 2024 •

edited

eessi-bot-aws bot commented Mar 13, 2024 •

edited

ocaisa Mar 13, 2024

ocaisa commented Mar 13, 2024

Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494

Improve error reported by bot when using unmerged EasyBuild PR in easystack file #494

Conversation

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 • edited

eessi-bot-aws bot commented Mar 9, 2024 • edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 • edited

eessi-bot-aws bot commented Mar 9, 2024 • edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 • edited

eessi-bot-aws bot commented Mar 9, 2024 • edited

casparvl commented Mar 9, 2024

eessi-bot-aws bot commented Mar 9, 2024 • edited

eessi-bot-aws bot commented Mar 9, 2024 • edited

ocaisa commented Mar 12, 2024

eessi-bot-aws bot commented Mar 12, 2024

eessi-bot-aws bot commented Mar 12, 2024

ocaisa commented Mar 13, 2024

eessi-bot-aws bot commented Mar 13, 2024 • edited

eessi-bot-aws bot commented Mar 13, 2024 • edited

ocaisa Mar 13, 2024

Choose a reason for hiding this comment

ocaisa commented Mar 13, 2024

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 9, 2024 •

edited

eessi-bot-aws bot commented Mar 13, 2024 •

edited

eessi-bot-aws bot commented Mar 13, 2024 •

edited