Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error reporting when EasyBuild PR is not merged #299

Merged

Conversation

trz42
Copy link
Collaborator

@trz42 trz42 commented Apr 5, 2024

This is a PR to sync NESSI with EESSI. See #294

Particularly this PR is for addressing code changes added to EESSI in EESSI#494

Here we simply pulled in changes for the three changed files in the EESSI PR (via git checkout casparvl/improve_error_on_unmerged_pr -- ONE_FILE with ONE_FILE in {check_missing_installations.sh, EESSI-install-software.sh, bot/check-build.sh) and thereafter changed back to using NESSI as name in two comments.

Since this PR involves quite a few changes we should test it with some basic PR building some software for EasyBuild PRs that are merged and not-merged (two separate tests).

Tests. We run a couple of tests with modifications by this PR and without them with EasyBuild easyconfig PRs that are merged or unmerged. Depending on the scenario, we should see differences in the reported outcome (FAILURE/SUCCESS) and differences in the ERROR message in cases of FAILURE. NOTE, the actual build should always succeed (need to check this carefully in the logs):

For letting CI succeed, #303 needs to get merged first.

@nessi-bot
Copy link

nessi-bot bot commented Apr 5, 2024

Instance AWS-MC-NESSI is configured to build:

  • arch x86_64/generic for repo nessi-2022.11-swl-deb10
  • arch x86_64/generic for repo nessi-2023.06-cl
  • arch x86_64/generic for repo nessi-2023.06-swl-deb10
  • arch x86_64/generic for repo nessi-2023.06-swl-deb11
  • arch x86_64/intel/skylake_avx512 for repo nessi-2022.11-swl-deb10
  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-cl
  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb10
  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb11
  • arch x86_64/amd/zen2 for repo nessi-2022.11-swl-deb10
  • arch x86_64/amd/zen2 for repo nessi-2023.06-cl
  • arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb10
  • arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb11
  • arch aarch64/generic for repo nessi-2022.11-swl-deb10
  • arch aarch64/generic for repo nessi-2023.06-cl
  • arch aarch64/generic for repo nessi-2023.06-swl-deb10
  • arch aarch64/generic for repo nessi-2023.06-swl-deb11

@nessi-bot
Copy link

nessi-bot bot commented Apr 5, 2024

Instance eX3-NESSI is configured to build:

  • arch x86_64/amd/zen2 for repo nessi-2023.06-cl
  • arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb10
  • arch x86_64/amd/zen2 for repo nessi-2023.06-swl-deb11
  • arch aarch64/generic for repo nessi-2023.06-cl
  • arch aarch64/generic for repo nessi-2023.06-swl-deb10
  • arch aarch64/generic for repo nessi-2023.06-swl-deb11

@nessi-bot
Copy link

nessi-bot bot commented Apr 5, 2024

Instance Fram-NESSI is configured to build:

  • arch x86_64/generic for repo nessi-2023.06-cl
  • arch x86_64/generic for repo nessi-2023.06-swl-deb10
  • arch x86_64/generic for repo nessi-2023.06-swl-deb11
  • arch x86_64/intel/broadwell for repo nessi-2023.06-cl
  • arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb10
  • arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb11

@nessi-bot
Copy link

nessi-bot bot commented Apr 5, 2024

Instance Saga-NESSI is configured to build:

  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-cl
  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb10
  • arch x86_64/intel/skylake_avx512 for repo nessi-2023.06-swl-deb11
  • arch x86_64/intel/broadwell for repo nessi-2023.06-cl
  • arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb10
  • arch x86_64/intel/broadwell for repo nessi-2023.06-swl-deb11
  • arch x86_64/generic for repo nessi-2023.06-cl
  • arch x86_64/generic for repo nessi-2023.06-swl-deb10
  • arch x86_64/generic for repo nessi-2023.06-swl-deb11

@trz42 trz42 mentioned this pull request Apr 6, 2024
Copy link

@poksumdo poksumdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test cases succeeded after including necessary changes. More work than thought it would be, but useful to get it right.

Integrated changes of two other related PRs.

@trz42 trz42 mentioned this pull request Apr 6, 2024
@poksumdo poksumdo merged commit d239c9f into NorESSI:nessi.no-2023.06 Apr 6, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants