-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Z3 dependency for PyTorch-2.1.2-foss-2023a.eb
#501
replace Z3 dependency for PyTorch-2.1.2-foss-2023a.eb
#501
Conversation
Instance
|
Hm, this is really due to the difference between the set of EasyConfigs used to build and the set of EasyConfig used when running For the build, because PyTorch is in https://github.com/EESSI/software-layer/blob/2023.06-software.eessi.io/easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-4.9.0-2023a.yml , we run Make me wonder if this actually makes sense. There was a good reason for it, as it allowed us to strip a lot of I need to think about what the best way is to proceed. This PR could work as a workaround. We could also explicitly install |
I would do the latter (installing The idea is to switch to using |
I'd be with @boegel here, the easy (and harmless) fix is to just install the new Z3 |
Obsolete after installing Z3 (#502) |
A recent change to the easyconfig
PyTorch-2.1.2-foss-2023a.eb
(see easybuilders/easybuild-easyconfigs#20050) lets the check for missing installations fail, for example, seehttps://github.com/EESSI/software-layer/actions/runs/8268611041/job/22621916438?pr=500#step:4:2130
This PR adds a hook that attempts to replace the dependency for Z3 with the version that was used before (with suffix
-Python-3.11.3
).CI should not fail anymore. However, running
eb
with--missing
prints messages that the dependency has been replaced, but the renamed dependency is then not listed anymore. Running with--dry-run
does show the renamed dependency. Not sure if this behaviour is expected or not.