-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings (and fix Z3 dependency for PyTorch 2.1.2 accordingly) #20050
Conversation
@boegelbot: please test @ generoso |
@lexming: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1980956047 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot: please test @ jsc-zen3 |
@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1988502973 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Failed test report is perfectly fine. Just 2 test from PyTorch failed, which is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @Micket |
Going in, thanks @lexming! |
Test report by @verdurin |
Via easybuilders/easybuild-easyconfigs#20050 , the different Z3 easyconfigs have been consolidated. This means the version used as a dependency for PyTorch has been "corrected" so we need to dance around that for our CI purposes
@@ -1,35 +1,51 @@ | |||
easyblock = 'CMakeMake' | |||
easyblock = 'PythonBundle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason this is a Python* Bundle* not a PythonPackage ? It only has a (single) Pythonpackage, doesn't it?
Maybe we can change/fix that in a followup. It just sticks out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flamefire because then z3-solver
is shown as an extension of the Z3 module, in case users search specifically for that name
(created using
eb --new-pr
)Use a single easyconfig of Z3 that has Python bindings:
lib
directory