Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings (and fix Z3 dependency for PyTorch 2.1.2 accordingly) #20050

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Mar 6, 2024

(created using eb --new-pr)

Use a single easyconfig of Z3 that has Python bindings:

  • rename Z3-4.12.2-GCCcore-12.3.0-Python-3.11.3.eb as Z3-4.12.2-GCCcore-12.3.0.eb
  • fix symlinks of libraries to make sure that all of them are present in the main lib directory

@lexming
Copy link
Contributor Author

lexming commented Mar 6, 2024

@boegelbot: please test @ generoso
EB_ARGS="Z3-4.12.2-GCCcore-12.3.0.eb PyTorch-2.1.2-foss-2023a.eb Clang-16.0.6-GCCcore-12.3.0.eb"

@lexming lexming added the bug fix label Mar 6, 2024
@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20050 EB_ARGS="Z3-4.12.2-GCCcore-12.3.0.eb PyTorch-2.1.2-foss-2023a.eb Clang-16.0.6-GCCcore-12.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20050 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13037

Test results coming soon (I hope)...

- notification for comment with ID 1980956047 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/8fdcddcd601b7c2e9e120721b98e76af for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Mar 11, 2024

@boegelbot: please test @ jsc-zen3
EB_ARGS="Z3-4.12.2-GCCcore-12.3.0.eb PyTorch-2.1.2-foss-2023a.eb Clang-16.0.6-GCCcore-12.3.0.eb"

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20050 EB_ARGS="Z3-4.12.2-GCCcore-12.3.0.eb PyTorch-2.1.2-foss-2023a.eb Clang-16.0.6-GCCcore-12.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20050 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3745

Test results coming soon (I hope)...

- notification for comment with ID 1988502973 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/7ac7d1a0e73868c60817cdc15e42417c for a full test report.

@lexming
Copy link
Contributor Author

lexming commented Mar 12, 2024

Failed test report is perfectly fine. Just 2 test from PyTorch failed, which is expected.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.0 milestone Mar 12, 2024
@Micket
Copy link
Contributor

Micket commented Mar 13, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/618e02df86b2e89866d2feef64918204 for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 13, 2024

Going in, thanks @lexming!

@Micket Micket merged commit 985b515 into easybuilders:develop Mar 13, 2024
9 checks passed
@lexming lexming deleted the 20240306115047_new_pr_Z34122 branch March 13, 2024 16:41
@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 14 out of 15 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/efefcb0ab754bedf613743d82b13e059 for a full test report.

ocaisa added a commit to EESSI/software-layer that referenced this pull request Mar 14, 2024
Via easybuilders/easybuild-easyconfigs#20050 , the different Z3 easyconfigs have been consolidated. This means the version used as a dependency for PyTorch has been "corrected" so we need to dance around that for our CI purposes
@boegel boegel changed the title {GCCcore/12.3.0} Unify Z3 easyconfigs into a single one with Python bindings {GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings Mar 14, 2024
@boegel boegel changed the title {GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings {GCCcore/12.3.0} Unify Z3 4.12.2 easyconfigs into a single one with Python bindings (and fix Z3 dependency for PyTorch 2.1.2 accordingly) Mar 14, 2024
@@ -1,35 +1,51 @@
easyblock = 'CMakeMake'
easyblock = 'PythonBundle'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason this is a Python* Bundle* not a PythonPackage ? It only has a (single) Pythonpackage, doesn't it?

Maybe we can change/fix that in a followup. It just sticks out here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flamefire because then z3-solver is shown as an extension of the Z3 module, in case users search specifically for that name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants