Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

[AV-Comparatives.org] Update and reactivate ruleset #10407

Merged
merged 6 commits into from Aug 3, 2017
Merged

[AV-Comparatives.org] Update and reactivate ruleset #10407

merged 6 commits into from Aug 3, 2017

Conversation

Bisaloo
Copy link
Collaborator

@Bisaloo Bisaloo commented Jun 15, 2017

@jeremyn
Copy link
Contributor

jeremyn commented Jun 15, 2017

Please rewrite this without the wildcard. Even if the certificate has a wildcard, individual domains may fail for other reasons.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

But wildcard DNS is literally the only case where we can cover all possible subdomains only through a wildcard ruleset.

How do you propose we protect this domain otherwise?

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

We can protect it by listing the specific domains like we normally do. #10307 (comment) is a current example of this.

I personally think there is almost no good use case for wildcards in rulesets. This has been discussed before, unfortunately I can't find a link. I know others disagree.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

Okay I think I get what you are asking. What you do in this case is try to find URLs that are meaningfully different and then protect those specifically. You can do this by seeing which URLs show up in Google searches, and by running Sublist3r and visiting all of the URLs returned. "Junk" URLs like adsfadsfas.example.com that are covered by the wildcard just don't get protected.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

It get the idea behind what you are proposing but IMO, it would make sense only if the website didn't choose this configuration on purpose.

I have always assumed they did that for analytical reasons. They would post site1.example.com on site1, site2.example.com on site2, etc. You can see it as some sort of referrer.

If what I am describing is true, then we should use a wildcard because it is the only way we can protect subdomains that are created on the fly.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

I'm not sure what you mean by "analytical reasons". Are you talking about https://www.av-comparatives.org in particular or all wildcard certificate sites in general?

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

I was talking about analytics. Now that you say it, I am not sure analytical can be used in that sense...

I am talking about wildcard DNS+certificate sites in general.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

I don't think we can assume a wildcard URL is for analytics. *.github.io and *.wordpress.com use wildcard certificates but that's not for analytics.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

This is why I said wildcard DNS+certificate.

EDIT: Maybe we don't mean the exact same thing when I talk about wildcard DNS. In this case, all subdomains redirect to www.av-comparatives.org (excepted a couple that are configured otherwise).

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Jun 16, 2017

Let's say I am the owner of av-comparatives.org. I want to put up a couple of links to www.av-comparatives.org on the web to advertise it to new users. But I would like to be able to know where people found about www.av-comparatives.org. So I post http://site1.av-comparatives.org on site1, http://site2.av-comparatives.org on site2. Everybody will reach www.av-comparatives.org in the end but my server log will reveal which link people used to get there. And I will know where my ads have been more effective.

It is also more powerful than traditional referers because if someone learns about www.av-comparatives.org on site1 and sends the link to their friends, I will still know the original source of the link.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

I get what you're saying now about DNS+certificate, thanks.

That's an unusual way to handle analytics. Most sites are going to use stuff like tokens in the URL, the referer header, or things like that. For av-comparatives.org in particular, Sublist3r reports only 19 subdomains including stuff like ww and wwww. I don't think they are using most of these domains for analytics.

@jeremyn
Copy link
Contributor

jeremyn commented Jun 16, 2017

@jeremyn jeremyn self-assigned this Aug 1, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Aug 1, 2017

Please let me know when this is ready for a "formal" review.

@Bisaloo
Copy link
Collaborator Author

Bisaloo commented Aug 2, 2017

@jeremyn, should be ready now

@jeremyn jeremyn merged commit 38acac5 into EFForg:master Aug 3, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Aug 3, 2017

Thanks, merged.

@jeremyn jeremyn removed their assignment Aug 3, 2017
@Bisaloo Bisaloo deleted the patch-4 branch August 3, 2017 16:16
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants