This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Fix host-only cookie duplication & leak #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we create duplicate cookies (!) for host-only cookies, one secure, one insecure. This is because we're always setting the domain parameter, regardless of the hostOnly value. See: http://developer.chrome.com/extensions/cookies.html#method-set Closes issue #159 Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
diracdeltas
added a commit
that referenced
this pull request
Apr 4, 2014
Fix host-only cookie duplication & leak
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we create duplicate cookies (!) for host-only cookies, one
secure, one insecure. This is because we're always setting the domain
parameter, regardless of the hostOnly value.
See: http://developer.chrome.com/extensions/cookies.html#method-set
Closes issue #159
Signed-off-by: Nick Semenkovich semenko@alum.mit.edu