Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Add new rulesets for pollin.de and dict.cc #1692

Closed
wants to merge 4 commits into from
Closed

Add new rulesets for pollin.de and dict.cc #1692

wants to merge 4 commits into from

Conversation

KurtKrampmeier
Copy link
Contributor

No description provided.

@KurtKrampmeier KurtKrampmeier changed the title Add new ruleset for pollin.de Add new rulesets for pollin.de and dict.cc May 14, 2015
@reedy
Copy link
Contributor

reedy commented May 14, 2015

failure: non-whitelisted downgrade rule in dict.cc redirects to http.
failure: dict.cc.xml failed test: Rule redirects to something other than https.

@KurtKrampmeier
Copy link
Contributor Author

So what would be the correct solution? Their frameset breaks https://www.dict.cc/dict/options.php, even without HTTPS Everywhere. I just followed the documentation on
https://www.eff.org/https-everywhere/rulesets#downgrades, which did not provide any information about whitelisting being necessary. What would be the policy for whitelisting?

Should I remove the downgrade rule and add a platform="mixedcontent" to the ruleset?

@reedy
Copy link
Contributor

reedy commented May 14, 2015

That's curious, you already have the downgrade="1" in place...

@reedy
Copy link
Contributor

reedy commented May 14, 2015

Oh, unless it's because of the exclusion AND the downgrade

@reedy
Copy link
Contributor

reedy commented May 16, 2015

Ah, you need to add it to https://github.com/EFForg/https-everywhere/blob/master/utils/downgrade-whitelist.txt

Also, use branches so you don't add other rulesets to existing PR

@J0WI J0WI mentioned this pull request Jun 17, 2015
@J0WI
Copy link
Contributor

J0WI commented Jul 10, 2015

@KurtKrampmeier there will be a new release soon. It would be great to have the dict.cc rule in.

@J0WI J0WI mentioned this pull request Oct 14, 2015
@semenko
Copy link
Contributor

semenko commented Dec 17, 2015

Looks like our tests are failing on this PR -- and it hasn't been updated in a while. I'm going to close this for now, but if you'd like it merged, feel free to re-open. Thanks! :)

@semenko semenko closed this Dec 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants