Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Create ruleset: W3C Test #17093

Merged
merged 3 commits into from Dec 30, 2018
Merged

Create ruleset: W3C Test #17093

merged 3 commits into from Dec 30, 2018

Conversation

FranklinYu
Copy link
Contributor

I skipped the punycode prefix xn-- in XML comment because it is illegal there. Punycode is not very common in the atlas; I found following examples:

<target host="xn--rksmrgs-5wao1o.josefsson.org" />

<test url="http://xn--z7h.js.org/" />

<ruleset name="мособлеирц.рф" default_off='failed ruleset test'>
<target host="xn--90aijkdmaud0d.xn--p1ai" />
<target host="www.xn--90aijkdmaud0d.xn--p1ai" />
<target host="xn--b1aoke0e.xn--90aijkdmaud0d.xn--p1ai" />
<target host="www.xn--b1aoke0e.xn--90aijkdmaud0d.xn--p1ai" />
<target host="xn--j1aab.xn--90aijkdmaud0d.xn--p1ai" />
<target host="www.xn--j1aab.xn--90aijkdmaud0d.xn--p1ai" />
<rule from="^http:" to="https:" />
</ruleset>

None of them added comment about the code.

@FranklinYu
Copy link
Contributor Author

Please also advise whether this ruleset should merge with https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/W3C.xml.

@FranklinYu
Copy link
Contributor Author

Anyone kindly review this PR?

@J0WI
Copy link
Contributor

J0WI commented Dec 21, 2018

LGTM, thanks!

Please also advise whether this ruleset should merge with https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/W3C.xml.

I prefer separate files, but you can add a hint in the comments of both rulesets, that they are related. Similar to what we do in Amazon.xml.

@J0WI J0WI merged commit cc11488 into EFForg:master Dec 30, 2018
@J0WI
Copy link
Contributor

J0WI commented Dec 30, 2018

Thanks!

@FranklinYu FranklinYu deleted the rules/w3c-test branch January 1, 2019 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants