This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
fixes #18103 #18104
Merged
fixes #18103 #18104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Killing `adb` server(aka daemon) prevents seeing groups of these messages on dmesg every second: [ 1460.763742] pcieport 0000:00:1c.4: restoring config space at offset 0x2c (was 0x0, writing 0x0) [ 1460.763748] pcieport 0000:00:1c.4: restoring config space at offset 0x28 (was 0x0, writing 0x0) [ 1460.763752] pcieport 0000:00:1c.4: restoring config space at offset 0x24 (was 0x1fff1, writing 0x1fff1) [ 1460.763813] pcieport 0000:00:1c.4: PME# disabled [ 1460.763920] xhci_hcd 0000:03:00.0: PME# disabled [ 1460.763928] xhci_hcd 0000:03:00.0: enabling bus mastering [ 1460.770239] xhci_hcd 0000:03:00.0: PME# enabled [ 1460.770377] xhci_hcd 0000:03:00.0: PME# disabled [ 1460.770383] xhci_hcd 0000:03:00.0: enabling bus mastering [ 1460.884813] xhci_hcd 0000:03:00.0: PME# enabled [ 1460.884925] pcieport 0000:00:1c.4: PME# enabled safety bonus: we only kill it if we started it.
|
view with hiding whitespace-changes: https://github.com/EFForg/https-everywhere/pull/18104/files?w=1 |
Hainish
reviewed
Jun 24, 2019
no need to futureproof an 'if' case (causing confusion) for when the "==" would be changed to an "-eq" and $we_started_adb_daemon would be empty.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Killing
adbserver(aka daemon) prevents seeing groups of these messageson
dmesgevery second:safety bonus: we only kill it if we started it.
issue is here: #18103