Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "share" button to the popup #2079

Closed
ghostwords opened this issue Jun 27, 2018 · 10 comments
Closed

Add a "share" button to the popup #2079

ghostwords opened this issue Jun 27, 2018 · 10 comments
Labels
enhancement good first issue help wanted translations ui User interface modifications; related to but not the same as the "ux" label ux User experience research needed

Comments

@ghostwords
Copy link
Member

As suggested via email:

I had clicked on the Privacy Badger [toolbar button] while at a favorite web site and was admiring (in horror) how many sites it had stopped tracking me when I suddenly realized that I needed to send a link to Privacy Badger to [a friend] who is also a user of the site in question and who currently suffers (without knowing it) from this very problem too. This requires assembling some information, such as the link to PB, the web site involved, the details of the blocked trackers, a personal recommendation into an email etc. This takes time and effort which makes me less likely to do it as time goes by.

I am not sure about adding another big button to the bottom of the popup, three are already a bit much. Since "sharing" and donating are related, perhaps we should rework the donate button while we are at it. Should we split the "donate" button into two buttons in the same row? UX suggestions most welcome!

@ghostwords ghostwords added enhancement ui User interface modifications; related to but not the same as the "ux" label help wanted ux User experience research needed good first issue labels Jun 27, 2018
@ghostwords
Copy link
Member Author

Sort of related to #1622 in that it's another situation where we have two related buttons that we may want to combine in some way.

@ghostwords
Copy link
Member Author

Similar popup UI button challenge in #827.

@troy-lamerton
Copy link
Contributor

To add a share button, it would need to be on a page that can be visited by anyone.

mailto can only include plaint text in the email body, so I don't think that is sufficient.

We could either:

  1. Publicly host pages that users can share
  2. Generate an image and upload it anonymously to a provider like Imgur.

@ghostwords let me know what you think and if option 1 is possible. I would be happy to work on either option.

@ghostwords
Copy link
Member Author

To add a share button, it would need to be on a page that can be visited by anyone.

I am not sure I understand your suggested workflow, please explain.

I was thinking we would generate some text and have that go into your clipboard so that you could paste it anywhere you wanted. Kind of like the Share on Twitter link in the new user intro. My uncertainty is more about where this new Share button should live.

@troy-lamerton
Copy link
Contributor

troy-lamerton commented Sep 9, 2018

screen shot 2018-09-09 at 20 36 25

What about this?

It could open a dropdown for email and twitter.

@ghostwords
Copy link
Member Author

ghostwords commented Sep 11, 2018

Good idea! I like this button placement much more than adding a fourth button to the bottom of the popup.

How do you see the dropdown working? I was thinking something like the following mockups:

pb-share-results
pb-results-copied

@troy-lamerton
Copy link
Contributor

I thought the dropdown would have buttons to do the same thing as those orange buttons in your mockups.
You would click the share button, dropdown opens, click on "Tweet about privacy badger" and then a twitter tab is opened with the tweet ready to tweet.

I like your mockups better though, I understand this would work similar to how the reporting a broken site replaces the whole popup interface.

@Jsnhlbr5
Copy link
Contributor

I am working on this, but have run into an issue with the site share buttons: only Twitter lets you provide arbitrary text in a simple share link. I haven't found anything better than linking to the G+/Facebook main page, hoping the user copied the text.

@ghostwords
Copy link
Member Author

ghostwords commented Oct 30, 2018

Hmm ... yeah, we can just omit those buttons for now. (Google+ is going away anyway ...) Or we could include them but make it clear somehow that they work differently. "Copy to clipboard" and "Share on Twitter" are on the same level of functionality, while "Share on Facebook" just starts posting a link to https://www.eff.org/privacybadger and the text will have to come manually.

Are there sharing dialog examples from other extensions/apps/programs we could review for UX?

Jsnhlbr5 added a commit to Jsnhlbr5/privacybadger that referenced this issue Oct 30, 2018
Also added incomplete "share to" buttons, but then commented them out (see
EFForg#2079 (comment)
for reasoning).
@Jsnhlbr5
Copy link
Contributor

I think generating the message so that it can be copied and subsequently pasted into the sharing medium of choice is enough (for now anyway). If there are very many trackers, the message becomes too long for Twitter, and without using the Facebook API (which requires an app id, and probably invokes tracking) we can do at best a half-job of creating the post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue help wanted translations ui User interface modifications; related to but not the same as the "ux" label ux User experience research needed
Projects
None yet
Development

No branches or pull requests

3 participants