-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "share" button to the popup #2079
Comments
Sort of related to #1622 in that it's another situation where we have two related buttons that we may want to combine in some way. |
Similar popup UI button challenge in #827. |
To add a share button, it would need to be on a page that can be visited by anyone.
We could either:
@ghostwords let me know what you think and if option 1 is possible. I would be happy to work on either option. |
I am not sure I understand your suggested workflow, please explain. I was thinking we would generate some text and have that go into your clipboard so that you could paste it anywhere you wanted. Kind of like the Share on Twitter link in the new user intro. My uncertainty is more about where this new Share button should live. |
I thought the dropdown would have buttons to do the same thing as those orange buttons in your mockups. I like your mockups better though, I understand this would work similar to how the reporting a broken site replaces the whole popup interface. |
I am working on this, but have run into an issue with the site share buttons: only Twitter lets you provide arbitrary text in a simple share link. I haven't found anything better than linking to the G+/Facebook main page, hoping the user copied the text. |
Hmm ... yeah, we can just omit those buttons for now. (Google+ is going away anyway ...) Or we could include them but make it clear somehow that they work differently. "Copy to clipboard" and "Share on Twitter" are on the same level of functionality, while "Share on Facebook" just starts posting a link to Are there sharing dialog examples from other extensions/apps/programs we could review for UX? |
Also added incomplete "share to" buttons, but then commented them out (see EFForg#2079 (comment) for reasoning).
I think generating the message so that it can be copied and subsequently pasted into the sharing medium of choice is enough (for now anyway). If there are very many trackers, the message becomes too long for Twitter, and without using the Facebook API (which requires an app id, and probably invokes tracking) we can do at best a half-job of creating the post. |
As suggested via email:
I am not sure about adding another big button to the bottom of the popup, three are already a bit much. Since "sharing" and donating are related, perhaps we should rework the donate button while we are at it. Should we split the "donate" button into two buttons in the same row? UX suggestions most welcome!
The text was updated successfully, but these errors were encountered: