Dialog to allow user to log in to third parties #219

cooperq · 2014-07-07T20:02:41Z

Creates the ability to have a dialog pop up when a user wants to log in to a third party to interact: e.g. disqus, youtube, instapaper, etc.

Conflicts: metadata.chrome

Conflicts: src/background.js src/popup.js src/webrequest.js

Conflicts: src/background.js src/webrequest.js

Conflicts: src/webrequest.js

…ly want to see facebook comments

…n on blocked domains

cooperq · 2014-07-07T23:29:59Z

This would fix #137

Conflicts: doc/sample_cookieblocklist.txt

diracdeltas · 2014-07-08T16:08:20Z

src/domainExceptions.js

+
+var exports = {};
+
+var DomainExceptions = {


Do you plan to eventually have this as an EFF-hosted list (similar to cookieblocklist.txt) so that this can be updated without an extension release?

It would be nice to modify the syntax of cookieblocklist.txt so this list could be incorporated into it.

On Tue, Jul 08, 2014 at 09:08:21AM -0700, Yan Zhu wrote:

Do you plan to eventually have this as an EFF-hosted list (similar to cookieblocklist.txt) so that this can be updated without an extension release?

It would be nice to modify the syntax of cookieblocklist.txt so this list could be incorporated into it.

Cookieblocklist.txt is in a format defined by ABP, so I don't think we
should modify it unless we find a way to stay ABP-compatible when doing
so.

But +1 on hosting it somewhere.

Peter Eckersley pde@eff.org
Technology Projects Director Tel +1 415 436 9333 x131
Electronic Frontier Foundation Fax +1 415 436 9993

@pde What are the consequences of breaking ABP compatibility?

@diracdeltas the consequence of breaking ABP compatibility is that the chrome version is still dependent on ABP code for it's blocking engine. I have a long term plan to remove this dependency but for now it's still there. We could break ABP compatibility and write some glue to turn the list into something that is abp compatible, but that seems unnecessary IMO.

I agree that it should be hosted somewhere instead of included inline. For now I think it should be hosted as a separate file. I will work on that.

Conflicts: doc/sample_cookieblocklist.txt

diracdeltas · 2014-07-15T18:25:28Z

This is coming along in Firefox. I realized today that the page-mod API either accepts wildcard domains or full URLs for matching, so annoyingly, the list needs to have separate entries for "http://etc" and "https://etc" (or I'll parse it into this form in Firefox after fetching it).

cooperq · 2014-07-15T19:00:59Z

@diracdeltas I decided to make the format of the domain exception list like so:

"<login url>": {"whitelist_urls": [<url 1>, <url 2>], "english_name": "<English Name>"}

for example:
"disqus.com/next/login": {"whitelist_urls": ["disqus.com"], "english_name":"Disqus"}

I think this provides the most clarity.

cooperq · 2014-07-15T19:34:51Z

@pde I have also removed protocol info from the domain exception list. At this point I think we are good to go.

pde · 2014-07-15T22:37:48Z

src/domainExceptionDialog.js

+        var K_ENTER = 13;
+        var K_TAB = 9;
+
+        document.addEventListener('keydown',function(e){


Do we need to remove this eventListener after we're done?

Yes we do, fixed.

…dgerchrome into feature/allow3rdparties

pde · 2014-07-16T20:02:12Z

I can't get this to fire anymore... perhaps we've broken it with the last few changes? What are you seeing, Cooper?

pde · 2014-07-16T21:57:43Z

OK, this is looking good enough for beta. Merging.

cooperq · 2014-07-16T23:01:33Z

Did you get it to fire?

pde · 2014-07-16T23:18:52Z

Yes, after removing/reinstalling Privacy Badger... so maybe there is
actually a lurking bug ...

On Wed, Jul 16, 2014 at 04:01:33PM -0700, Cooper Quintin wrote:

Did you get it to fire?

Reply to this email directly or view it on GitHub:
#219 (comment)

Peter Eckersley pde@eff.org
Technology Projects Director Tel +1 415 436 9333 x131
Electronic Frontier Foundation Fax +1 415 436 9993

pde · 2014-07-17T01:45:42Z

I can actually reproduce the problem now.

Step 1: comment on Youtube, whitelist to allow the login

Step 2: (may not be required) uninstall Privacy Badger, reinstall

Step 3: logout from Youtube, try to comment on Youtube again (Youtube will ask you to login)

Step 4: after login, clicking in the compose comment box causes an apparent page rerender/reload event, and does not give you focus.

Each time the page reloads the console logs from within the YouTube DOM are:

clobbering cookie getter VM6019:1
clobbering cookies for 
Location {replace: function, assign: function, ancestorOrigins: DOMStringList, origin: "https://plus.google.com", hash: "#id=I0_1405556862746&parent=https%3A%2F%2Fapis.goo….com&pfname=%2FI0_1405556787752&rpctoken=10363102"…}
 clobbercookie.js:19
clobbering cookies for 
Location {replace: function, assign: function, ancestorOrigins: DOMStringList, origin: "https://apis.google.com", hash: "#_methods=onPlusOne%2C_ready%2C_close%2C_open%2C_r…3A%2F%2Fwww.youtube.com&pfname=&rpctoken=34709718"…}
 clobbercookie.js:19

The console logs from within Privacy Badger are:

blacklisting origin plus.google.com heuristicblocking.js:655
forgetting tab 106 webrequest.js:207
blacklisting origin apis.google.com heuristicblocking.js:655
tab removed! 106 webrequest.js:72
forgetting tab 106 webrequest.js:207
Unchecked runtime.lastError while running browserAction.setBadgeBackgroundColor: No tab with id: 106.
    at updateCount (chrome-extension://fgggbcohhecmabjgjnfmpdfaadapjckp/src/background.js:724:26) extensions::sendRequest:86
Unchecked runtime.lastError while running browserAction.setBadgeText: No tab with id: 106.
    at updateCount (chrome-extension://fgggbcohhecmabjgjnfmpdfaadapjckp/src/background.js:729:24) extensions::sendRequest:86
Unchecked runtime.lastError while running browserAction.setBadgeBackgroundColor: No tab with id: 106.
    at updateCount (chrome-extension://fgggbcohhecmabjgjnfmpdfaadapjckp/src/background.js:724:26) extensions::sendRequest:86
Unchecked runtime.lastError while running browserAction.setBadgeText: No tab with id: 106.
    at updateCount (chrome-extension://fgggbcohhecmabjgjnfmpdfaadapjckp/src/background.js:729:24) extensions::sendRequest:86
4
blacklisting origin api

cooperq · 2014-07-17T23:16:00Z

I can't reproduce this problem even following the steps you outlined. However I do know what is causing that console error. So I will fix that and see if it does anything.

Conflicts: src/webrequest.js

cooperq · 2014-07-18T00:00:50Z

These commits should fix the console error that @pde was seeing. I'm still unable to reproduce the problem. Going to merge since it is time to release.

Dialog to allow user to log in to third parties

diracdeltas · 2014-07-23T23:38:32Z

src/webrequest.js

+        saveAction('noaction', whitelistDomains[i], getHostForTab(tabId));
+        reloadTab(tabId);
+      }
+      if(msg.action === "not_now"){


shouldn't this be "never" instead of "not_now"?

Yes it should. There should be an x in the corner of the popup which
amounts to "not now". Pressing escape, or clicking outside the popup,
should have the "not now" effect too...

On Wed, Jul 23, 2014 at 04:38:32PM -0700, Yan Zhu wrote:

+function _askUserToWhitelist(tabId, whitelistDomains, englishName){

console.log('assking user to whitelist');

var port = chrome.tabs.connect(tabId);

port.postMessage({action: 'attemptWhitelist', whitelistDomain:englishName, currentDomain:getHostForTab(tabId)});

port.onMessage.addListener(function(msg){

for(var i = 0; i < whitelistDomains.length; i++){

if(msg.action === "allow_all"){

saveAction('noaction', whitelistDomains[i]);

reloadTab(tabId);

}

if(msg.action === "allow_once"){

//allow blag on this site only

saveAction('noaction', whitelistDomains[i], getHostForTab(tabId));

reloadTab(tabId);

}

if(msg.action === "not_now"){

shouldn't this be "never" instead of "not_now"?

Reply to this email directly or view it on GitHub:
https://github.com/EFForg/privacybadgerchrome/pull/219/files#r15322886

Peter Eckersley pde@eff.org
Technology Projects Director Tel +1 415 436 9333 x131
Electronic Frontier Foundation Fax +1 415 436 9993

cooperq and others added 22 commits May 9, 2014 18:43

basic popup to allow users to unblock oauth sites

1abad53

Merge branch 'master' into feature/allow3rdparties

5d41989

Merge branch 'master' into feature/allow3rdparties

22a7667

Conflicts: metadata.chrome

move domainExceptions to src and add require boilerplate around it

31f78a8

Merge branch 'cookiehandlingexperiment' into feature/allow3rdparties

07d0361

Conflicts: src/background.js src/popup.js src/webrequest.js

refactor domain exceptions

682e651

Merge branch 'cookiehandlingexperiment' into feature/allow3rdparties

b53c876

Merge branch 'master' into feature/allow3rdparties

967014c

Conflicts: src/background.js src/webrequest.js

Merge branch 'master' into feature/allow3rdparties

042f2fb

Conflicts: src/webrequest.js

Merge branch 'master' into feature/allow3rdparties

a7afa53

Merge branch 'master' into feature/allow3rdparties

3f225ce

basic dialog for user choice on whitelisting 3rd parties

308af11

make filter to whitelist 3rd parties on a specific first party work

14d1fb3

undo button works on per-domain filters

767cd0c

css for privacy badger popup

2096b8f

refactor domain exception object, make popup more clear

5b4912f

make sure page css does not mess with our popup

1c591ca

add instapaper, pocket, kinja and facebook connect to popup list

ad5c55f

adding www.facebook.com to cookie block list because some people real…

3be5ce1

…ly want to see facebook comments

Making popup box bigger

0aea312

adding hootsuite hootlet

6b3f79b

move domain exception popup to before request handler so it fires eve…

461638a

…n on blocked domains

Merge branch 'master' into feature/allow3rdparties

75f7f35

Conflicts: doc/sample_cookieblocklist.txt

diracdeltas reviewed Jul 8, 2014
View reviewed changes

cooperq added the enhancement label Jul 8, 2014

cooperq added this to the Privacy Badger Beta/version 0.2 milestone Jul 8, 2014

Merge branch 'master' into feature/allow3rdparties

2faf08d

Conflicts: doc/sample_cookieblocklist.txt

cooperq self-assigned this Jul 8, 2014

move domain exception list to EFF server

a101345

semicolons

0bd9dbe

refactoring domain exception list format

cd723c4

remove protocol information from domain exception list

2a64ad8

Comment the run-once fix

aead1d0

pde reviewed Jul 15, 2014
View reviewed changes

cooperq added 3 commits July 16, 2014 13:44

unregister event listener after user interaction

7c5ed5d

Merge branch 'feature/allow3rdparties' of github.com:EFForg/privacyba…

319bc3b

…dgerchrome into feature/allow3rdparties

adding comments

7d84b60

cooperq added 3 commits July 17, 2014 19:45

reinitialize frames when privacy badger is updated

6c30d6b

run all interval functions when badger is updated

22569c5

Merge branch 'master' into feature/allow3rdparties

72a1e98

Conflicts: src/webrequest.js

cooperq added a commit that referenced this pull request Jul 18, 2014

Merge pull request #219 from EFForg/feature/allow3rdparties

d8eb923

Dialog to allow user to log in to third parties

cooperq merged commit d8eb923 into master Jul 18, 2014

diracdeltas reviewed Jul 23, 2014
View reviewed changes

ghostwords added broken site heuristic Badger's core learning-what-to-block functionality ui User interface modifications; related to but not the same as the "ux" label widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets labels Aug 2, 2017

ghostwords mentioned this pull request Jan 4, 2018

Privacy Badger breaks some deliberate third party interactions such as oAuth with facebook youtube disqus etc. #137

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dialog to allow user to log in to third parties #219

Dialog to allow user to log in to third parties #219

cooperq commented Jul 7, 2014

cooperq commented Jul 7, 2014

diracdeltas Jul 8, 2014

pde Jul 8, 2014

diracdeltas Jul 8, 2014

cooperq Jul 8, 2014

diracdeltas commented Jul 15, 2014

cooperq commented Jul 15, 2014

cooperq commented Jul 15, 2014

pde Jul 15, 2014

cooperq Jul 16, 2014

pde commented Jul 16, 2014

pde commented Jul 16, 2014

cooperq commented Jul 16, 2014

pde commented Jul 16, 2014

pde commented Jul 17, 2014

cooperq commented Jul 17, 2014

cooperq commented Jul 18, 2014

diracdeltas Jul 23, 2014

pde Jul 23, 2014

Dialog to allow user to log in to third parties #219

Dialog to allow user to log in to third parties #219

Conversation

cooperq commented Jul 7, 2014

cooperq commented Jul 7, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diracdeltas commented Jul 15, 2014

cooperq commented Jul 15, 2014

cooperq commented Jul 15, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pde commented Jul 16, 2014

pde commented Jul 16, 2014

cooperq commented Jul 16, 2014

pde commented Jul 16, 2014

pde commented Jul 17, 2014

cooperq commented Jul 17, 2014

cooperq commented Jul 18, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment