Show Google Sign-In "breakage note" tooltip for accounts.google.com #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When blocked by default.
For accounts.google.com (Google Sign-In)
ghostwords
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #137.
The tooltip is shown once, when you first open the popup for a page where Privacy Badger (cookie)blocked
accounts.google.comby default.The sliders section will then be open, same as when there are any breakage warnings. The slider for
accounts.google.comwill get shown at the top, before any other sliders. Same as breakage warning sliders, but above them too.The tooltip stays open while you click (or tap) to move the slider.
You can dismiss the tooltip by clicking on it. There is currently no way to show it again.
We don't do any of this for sliders on the options page.
This could be followed up by adding other breakage notes, perhaps for Twitch (#2540 / #2785).