-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving new code from previous repository & releasing it #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to also do the release 2.0.0 (atm is 2.0.0-SNAPSHOT) please use the plugin to do the release. Also modify the documentation and scripts accordingly.
EGA-archive/ega-data-api#168 Change of name from filePath into displayFilePath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is not to modify manually the files, that is why we are including the maven release plugin, to let it do it for you with the benefit of creating all the necessary commits and tags.
Also, you will want to modify the execution script so that it is agnostic of the version and just runs the last version jar available on the target directory instead as that can't be automatized to be changed when doing releases.
Added the version to 2.0.0-SNAPSHOT and changed the shell script to automatically get the jar from the target directory. Let me know if something is still missing |
This code has been moved from previous repository https://github.com/EGA-archive/ega-fuse into this repository.
Only the new changes checked is in the 2nd commit where I'm adding the release plugin