-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishers: stdout and AMS #178
Conversation
AMS support is broken in python3 :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
Could you please add some documentation before we merge this?
And what is the status of tests?
Last point, should we release a version before this is merged, or should we wait for it?
yes, will do in a subsequent commit
I'm now testing with the catch-all stuff, will check with AppDB if they are still getting the same information
I think is better to wait, as I want ONE providers to use this directly |
Only working for python 2 :(
I believe now it's ready, @gwarf take a look when you can |
Co-Authored-By: Baptiste Grenier <baptiste@bapt.name>
Co-Authored-By: Baptiste Grenier <baptiste@bapt.name>
Co-Authored-By: Baptiste Grenier <baptiste@bapt.name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few small typos, maybe some doc strings on all new methods would be nicer, but it's fine with me.
This will allow AMS to get the right topic automatically
Summary
This PR brings pluggable support for the output. 2 initial publishers are provided:
stdout
(the one we already had) andams
for pushing messages to ARGO AMS