Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore file for gitleaks, but disable gitlekas as ignore file is not working yet #511

Merged
merged 8 commits into from
Oct 19, 2022

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Oct 14, 2022

Only look at current tree, not at git history

Only look at current tree, not at git history
@enolfc
Copy link
Contributor

enolfc commented Oct 14, 2022

LGTM

@gwarf
Copy link
Member Author

gwarf commented Oct 17, 2022

I wasn't yet able to find a way to make this work, but I'm not yet sure if it's due to our env, or just a broken/buggy feature.
For the record I've asked some feedback in a (unfortunately closed) issue: https://github.com/github/super-linter/issues/3407

We may want to test/debug super-linter locally, to see what it does.

@gwarf
Copy link
Member Author

gwarf commented Oct 18, 2022

@enolfc the gitleaks exclusion file not being working for now, and this check being breaking all PR for now, should we just disable it for some time?

@enolfc
Copy link
Contributor

enolfc commented Oct 19, 2022

@enolfc the gitleaks exclusion file not being working for now, and this check being breaking all PR for now, should we just disable it for some time?

Ok, let's disable it.
But we should remind ourselves this needs to be fixed in the future

@gwarf gwarf changed the title Add ignore file for gitleaks Add ignore file for gitleaks, but disable gitlekas as ignore file is not working yet Oct 19, 2022
@gwarf gwarf merged commit 35b35f7 into EGI-Federation:main Oct 19, 2022
@gwarf gwarf deleted the gitleaks_exceptions branch October 19, 2022 08:31
@gwarf gwarf mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants