Version 2.2.4 #400
Merged
Version 2.2.4 #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes some text appear too large on the screen (menu and lists)
…anding on strand, redundancy and ORF checks during prepare.
…cal details for the configuration.
- Adds global table of contents to the sidebar - Better fitting of wide tables to the page
…cripts. Minor updates to the docs.
…ch should only be about the docs)
… Starting to have a solution for #395
This is a tentative approach at expanding the uses of attributes as part of the scoring, includes a minimal test case but is still missing other categories for these could be present (not_fragmentary and the main requirements), currently these are only tested for the scoring section and minimally with this commit for the as_requirements section.
This is testing for use of attributes as cds_requirements, curiously, the 'cdna_length' attribute is 'swallowed' by mikado if set directly on the object, but 'something' is not. This needs to be checked as collisions on names that are handled specially should be validated at the configuration parsing stage.
…trics file. Added 'default' key to the filering (for compatibility with attributes). All properly tested.
This was
linked to
issues
Apr 1, 2021
Checking if the key startswith "attribute.", only splitting a single '.' and checking there's something after the '.' is a bit more precise than just checking if 'attributes' appears in the key name and using unbounded splitting. Expanding the documentation of the transcript attributes use for scoring.
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 85.38% 85.30% -0.09%
==========================================
Files 110 110
Lines 19465 19614 +149
==========================================
+ Hits 16620 16731 +111
- Misses 2845 2883 +38 |
…er objects would not have had their ORF checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #136 #397 #395 #396 #389