Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cleanup #355

Closed

Conversation

maxalbert
Copy link
Contributor

Allow pandas 0.16.x and remove special dependency_link for music21 (since versions >= 2.0.3 were released a while ago).

@mrbannon
Copy link
Contributor

Thanks. I've actually got the same fix in my branch, but I'll make sure
you're credited. :)
On Aug 16, 2015 1:04 PM, "maxalbert" notifications@github.com wrote:

Allow pandas 0.16.x and remove special dependency_link for music21 (since

versions >= 2.0.3 were released a while ago).

You can view, comment on, or merge this pull request online at:

#355
Commit Summary

  • Allow pandas version 0.16.x in requirements.
  • Remove special dependency link for music21 because versions >=2.0.3
    were released a while ago.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#355.

@maxalbert
Copy link
Contributor Author

Ah, great! Don't worry about the credit if it's any hassle at all. So long as the change somehow makes it into the repo I'm happy. :)

By the way, for future reference, which branch is it usually best to submit PRs against? I checked develop, and it still has the requirement pandas<0.16, but I didn't check any other branches.

@mrbannon
Copy link
Contributor

Develop. Pandas is one dep. I forgot to check, so thanks for that.
On Aug 16, 2015 13:35, "maxalbert" notifications@github.com wrote:

Ah, great! Don't worry about the credit if it's any hassle at all. So long
as the change somehow makes it into the repo I'm happy. :)

By the way, for future reference, which branch is it usually best to
submit PRs against? I checked develop, and it still has the requirement
pandas<0.16, but I didn't check any other branches.


Reply to this email directly or view it on GitHub
#355 (comment)
.

@mrbannon
Copy link
Contributor

Taken care of in other pulls/commits.

@mrbannon mrbannon closed this Aug 17, 2015
@maxalbert maxalbert deleted the tidy_up_dependencies branch August 17, 2015 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants