-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made label
optional in the parse strategy
#252
Conversation
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 90.00% 90.04% +0.04%
==========================================
Files 15 15
Lines 450 452 +2
==========================================
+ Hits 405 407 +2
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I orignially approved, but it does not work. I have added a fix.
However, there was not test for this core strategy, and this is something to be remedied immediately. I have started on a test, but please complete it.
NB! when adding the test, it became clear that the 'driver' in 'configuration' cannot be optional, so I hgave removed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Description:
Made label optional in the parse strategy. Added unused metadata field.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.