Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made label optional in the parse strategy #252

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Conversation

jesper-friis
Copy link
Contributor

Description:

Made label optional in the parse strategy. Added unused metadata field.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

jesper-friis and others added 2 commits June 24, 2024 15:23
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (2d1330d) to head (d92949c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   90.00%   90.04%   +0.04%     
==========================================
  Files          15       15              
  Lines         450      452       +2     
==========================================
+ Hits          405      407       +2     
  Misses         45       45              
Flag Coverage Δ
linux 90.04% <100.00%> (+0.04%) ⬆️
windows 90.04% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I orignially approved, but it does not work. I have added a fix.

However, there was not test for this core strategy, and this is something to be remedied immediately. I have started on a test, but please complete it.

NB! when adding the test, it became clear that the 'driver' in 'configuration' cannot be optional, so I hgave removed that.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@jesper-friis jesper-friis merged commit 9ce67ba into master Jun 25, 2024
10 checks passed
@jesper-friis jesper-friis deleted the optional-parse-label branch June 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants