-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace CaperURI with AutoURI #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not installed)
paul-sud
requested changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments
Co-Authored-By: Paul Sud <41386393+p-sud@users.noreply.github.com>
Co-Authored-By: Paul Sud <41386393+p-sud@users.noreply.github.com>
paul-sud
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
gabdank
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have replaced old localization module (Caper's
CaperURI
) with a new one (Autouri'sAutoURI
).Deprecated parameters
--http-user
and--http-password
: Autouri automatically uses~/.netrc
file for authentication of HTTP URLs. Use~/.netrc
file.--use-gsutil-over-aws-s3
: Old module usedaws s3
CLI for S3 files andgsutil
for GCS files. This parameter is no longer needed since new model uses Python interfaces instead of CLIs.Added parameters
--verbose
(-V
) and--debug
(-D
): Prints detailed logs.verbose >= INFO
,debug >= DEBUG
.--use-gsutil-for-s3
: This is different from the deprecated parameter--use-gsutil-over-aws-s3
. Old loc module usedgsutil
CLI for file transfer between GCS (gs://
) and any other. But new module optionally (controlled by this parameter) usesgsutil
only for direct file transfer between GCS and S3 (s3://
). If this flag is turned ongsutil
will be used only for such direct file transfer.Bug fixes
--tmp_dir
was not checked correctly (when it's on$CWD
).--no-graph
: This will be removed, Croo will automatically check ifdot
executable exists on$PATH
. This is a bit annoying sincepip install graphviz
does not install this important executabledot
. Users can only get it with system-level installation command likesudo apt-get install graphviz
.Important notice