Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace CaperURI with AutoURI #15

Merged
merged 11 commits into from
Mar 30, 2020
Merged

replace CaperURI with AutoURI #15

merged 11 commits into from
Mar 30, 2020

Conversation

leepc12
Copy link
Contributor

@leepc12 leepc12 commented Mar 25, 2020

We have replaced old localization module (Caper's CaperURI) with a new one (Autouri's AutoURI).

  • Deprecated parameters

    • --http-user and --http-password: Autouri automatically uses ~/.netrc file for authentication of HTTP URLs. Use ~/.netrc file.
    • --use-gsutil-over-aws-s3: Old module used aws s3 CLI for S3 files and gsutil for GCS files. This parameter is no longer needed since new model uses Python interfaces instead of CLIs.
  • Added parameters

    • --verbose (-V) and --debug (-D): Prints detailed logs. verbose >= INFO, debug >= DEBUG.
    • --use-gsutil-for-s3: This is different from the deprecated parameter --use-gsutil-over-aws-s3. Old loc module used gsutil CLI for file transfer between GCS (gs://) and any other. But new module optionally (controlled by this parameter) uses gsutil only for direct file transfer between GCS and S3 (s3://). If this flag is turned on gsutil will be used only for such direct file transfer.
  • Bug fixes

    • --tmp_dir was not checked correctly (when it's on $CWD).
    • --no-graph: This will be removed, Croo will automatically check if dot executable exists on $PATH. This is a bit annoying since pip install graphviz does not install this important executable dot. Users can only get it with system-level installation command like sudo apt-get install graphviz.
  • Important notice

    • UCSC browser web page no longer accepts long URL (where full track hub text is encoded in such URL). So instead, Croo makes another alternative link with a linked track hub txt file instead of a full track hub text. One issue is that this text file should be public. So this track hub txt file will be converted into public URL (according to parameters defined by users). e.g. being presigned on GCS.

@leepc12 leepc12 requested a review from paul-sud March 27, 2020 21:33
Copy link
Contributor

@paul-sud paul-sud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments

croo/croo.py Outdated Show resolved Hide resolved
croo/croo_args.py Outdated Show resolved Hide resolved
croo/croo_args.py Outdated Show resolved Hide resolved
leepc12 and others added 4 commits March 27, 2020 15:53
Co-Authored-By: Paul Sud <41386393+p-sud@users.noreply.github.com>
Co-Authored-By: Paul Sud <41386393+p-sud@users.noreply.github.com>
Copy link
Contributor

@paul-sud paul-sud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@leepc12 leepc12 merged commit b3eef39 into dev Mar 30, 2020
@leepc12 leepc12 deleted the PIP-987_autouri branch March 30, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants