SNO-177-add-view-with-specified-fields #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keenangraham
commented
Oct 21, 2020
src/snovault/auditor.py
Outdated
| @@ -244,8 +244,9 @@ def item_view_audit(context, request): | |||
| path = request.resource_path(context) | |||
| properties = request.embed(path, '@@object') | |||
| inherit = context.audit_inherit | |||
| if context.embedded and '*' in context.audit_inherit: | |||
| inherit = context.embedded | |||
| embedded_paths = list(context.embedded) + [p.path for p in context.embedded_with_frame] | |||
There was a problem hiding this comment.
There are a couple places where we have to iterate over these paths. Think I could make this cleaner by just having a property that implements this logic once instead of leaking internals every time we have to do this.
pedrohr
reviewed
Oct 21, 2020
src/snovault/auditor.py
Outdated
| @@ -244,8 +244,9 @@ def item_view_audit(context, request): | |||
| path = request.resource_path(context) | |||
| properties = request.embed(path, '@@object') | |||
| inherit = context.audit_inherit | |||
| if context.embedded and '*' in context.audit_inherit: | |||
| inherit = context.embedded | |||
| embedded_paths = list(context.embedded) + [p.path for p in context.embedded_with_frame] | |||
There was a problem hiding this comment.
does context.embedded_with_frame raise an exception if the context doesn't have it set?
|
Shouldn't have any functional change, put embedded and embedded_with_frame iteration logic in embedded_paths |
pedrohr
approved these changes
Oct 27, 2020
keenangraham
force-pushed
the
SNO-177-add-view-with-specified-fields
branch
from
756b156
to
a72053a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.