-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework baselines #25
Rework baselines #25
Conversation
+ Update ResNet baseline 🔨 + Update models 🔨
You also moved loading weights inside the model! One step further to solving #11 |
if ds_name == "cifar10" or ds_name == "cifar100": | ||
procedure = optim_cifar10_wideresnet | ||
|
||
if model_name == "batch_ensemble": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be:
if model_name == "batched":
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. However, is batched the correct name? Calling BatchEnsemble "batched" may amount to some form of appropriation. (says the guy that called BatchEnsemble "BatchEnsembles" twice in the commits 😆)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the optimizer, but we may need to look at the names we gave to the different methods.
Fix tests ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look nice!
Current baseline implementations carry lots of repetitions. To simplify them this pull request proposes the following changes:
These changes are expected to: