Use promises #2
Merged
Use promises #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use string interpolation
Add default value
Use query params
Use four spaces
Fix indentation
Use arrow function
Use promises
|
Wow! Very impressive and cool! Just saw that you forked my repo and I already saw that you want to implement promises... Pretty cool thing! I will test it now and then, if everything is OK, I will merge this! Thank you so far for your contribution! |
|
Everything looked good! Thank you for your contribution! 👍 📻 |
|
The latest version (v0.3.0) can now be found at npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using promises we can chain multiple requests without having to worry about concurrency