This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
cache key values in iterator store in db_context_rocksdb #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
suggested changes
Feb 26, 2021
brianjohnson5972
approved these changes
Mar 18, 2021
|
|
||
| const payer_payload pp{payer, value, value_size}; | ||
| set_value(old_key_value.full_key, pp); | ||
| prefix_bundle old_key = get_primary_slice_in_primaries(table_store.contract, table_store.scope,table_store.table, key_store.primary); |
There was a problem hiding this comment.
get_primary_slice_in_primaries creates an extra key that we don't use, so we could create a new method that just creates the key_bundle instead of a prefix_bundle.
There was a problem hiding this comment.
Thanks for your suggestion. Will create a new method in a future PR in the performance activity.
| } | ||
|
|
||
| current_session.erase(old_key_value.full_key); | ||
| primary_lookup.remove_table_if_empty(old_key_value.full_key); | ||
| prefix_bundle old_key = get_primary_slice_in_primaries(table_store.contract, table_store.scope,table_store.table, key_store.primary); |
There was a problem hiding this comment.
other comment applies here as well
There was a problem hiding this comment.
Will do it in a future PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
https://blockone.atlassian.net/browse/EPE-786
Cache primary key values when first retrieving them in
db_find_i64and iterator functions.Use them in
db_get_i64,db_update_i64, anddb_remove_i64.This PR is based on Brian's #9997. Thanks Brian. It fixes a bug in the original PR, and makes
db_update_i64anddb_move_i64to use cached values too.Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions