This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix misleading error msg when port==walletport #2574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will conflict with #2555 |
heifner
suggested changes
Apr 25, 2018
| std::cerr << localized("Failed to connect to nodeos at ${ip}:${port}; is nodeos running?", ("ip", host)("port", port)) << std::endl; | ||
| } else if (errorString.find(fc::json::to_string(wallet_port)) != string::npos) { | ||
| } else if (errorString.find(wallet_host + ":" + fc::json::to_string(wallet_port)) != string::npos) { |
There was a problem hiding this comment.
Should that be "wallet-host" instead of "wallet_host"?
There was a problem hiding this comment.
These lines don't even exist after the merged HTTPS support, I had to refactor this logic in to what I hope is a little cleaner.
I'm not sure the original defect still exists in my refactor or not.
|
@taokayan see the comments, do you want to close this PR or do you think it should still be merged? |
|
Hi Greg,
I think it's better to close it right now, as we have more important tests
to finish. Today is hk holiday that we are not working.
Cheers,
Kayan
On 1 May 2018 12:53, "Greg Lee" <notifications@github.com> wrote:
@taokayan <https://github.com/taokayan> see the comments, do you want to
close this PR or do you think it should still be merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2574 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AjYOOsV6MdNLBq2NEyFgKjJCY56YElVjks5tt-o3gaJpZM4ThYSD>
.
|
|
OBE |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2256 improve cleos error msg