This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add HTTPS support (in addition to HTTP) for cleos #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HTTPS support for cleos when talking to nodeos and keosd. This removes the -H, -P, and --wallet-* options in favor of options that specify the server as an entire URL such as https://server:8888/
|
Woohoo! 🎉 This is the best PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTPS support to cleos
🚨Command line options have changed 🚨
To prevent having yet another option for HTTP vs HTTPS I have elected to replace the separate port and host options with a combined --url/-u option. This breaks old usage (with a message to use the new option)
Part of #2253