This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix soft_fail billing bug #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
added
bug
CONSENSUS
bytemaster
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sender of a generated transactions is added as an authorizer (with active permission) to the
eosio::onerroraction delivered to the sender's contract. This is needed to properly bill someone onsoft_fails. If a blockchain generated with v1.0.1 has deferred transactionsoft_fails, it is possible but not guaranteed that v1.0.2 will be unable to replay it. Thus this change introduces a potential consensus-breaking change.