Fix null pointer dereference while find_plugin #5082

spartucus · 2018-08-07T07:49:54Z

There are chances that application::find_pluginreturn nullptr, so it's safer to EOS_ASSERT all before dereference plugin pointer. While mongo_db_plugin.cpp and sql_db_plugin.cpp did the job.

Although it has fewer chance chain_plugin is invalid, still it's safer to assert it.

Although there are fewer chances that chain_plugin is invalid, still it's safer to assert it.

spartucus added 3 commits August 7, 2018 15:34

Fix null pointer dereference

d5eb2b7

Although it has fewer chance chain_plugin is invalid, still it's safer to assert it.

Fix null pointer dereference

4bef903

Although there are fewer chances that chain_plugin is invalid, still it's safer to assert it.

Fix null pointer dereference

f256c1b

Although there are fewer chances that chain_plugin is invalid, still it's safer to assert it.

heifner changed the base branch from master to develop August 8, 2018 12:39

heifner approved these changes Aug 9, 2018

View reviewed changes

heifner merged commit f04e151 into EOSIO:develop Aug 9, 2018

spartucus deleted the patch-2 branch August 10, 2018 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix null pointer dereference while find_plugin #5082

Fix null pointer dereference while find_plugin #5082

spartucus commented Aug 7, 2018 •

edited

Loading

Fix null pointer dereference while find_plugin #5082

Fix null pointer dereference while find_plugin #5082

Conversation

spartucus commented Aug 7, 2018 • edited Loading

spartucus commented Aug 7, 2018 •

edited

Loading