This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Multi-thread transaction key recovery #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanderingbort
approved these changes
Oct 26, 2018
| @@ -25,6 +26,7 @@ struct block_header_state { | |||
| public_key_type block_signing_key; | |||
| vector<uint8_t> confirm_count; | |||
| vector<header_confirmation> confirmations; | |||
| std::shared_future<public_key_type> block_signing_key_future; | |||
There was a problem hiding this comment.
This doesn't seem to be used? was there some files left out of this PR (despite it operating fine)? Or is this future expansion
There was a problem hiding this comment.
I was experimenting with block signing future. I'll remove this.
This was referenced Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
None
API Changes
-- chain-threads - number of threads for the controller thread_pool. Currently used for transaction key recovery, but could be used for other operations in the future.
Documentation Additions
chain-threads- number of threads to use for transaction key recovery when applying a signed block.