This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
net_plugin more quickly determine known block #6735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
plugins/net_plugin/net_plugin.cpp
Outdated
|
|
||
| char* header = reinterpret_cast<char*>(&payload_size); | ||
| size_t header_size = sizeof(payload_size); | ||
| char* header = reinterpret_cast<char*>(&payload_size); // avoid variable size encoding of uint32_t |
There was a problem hiding this comment.
If you want to be OCD like me you can make this "char* const " I think
plugins/net_plugin/net_plugin.cpp
Outdated
| size_t header_size = sizeof(payload_size); | ||
| char* header = reinterpret_cast<char*>(&payload_size); // avoid variable size encoding of uint32_t | ||
| constexpr size_t header_size = sizeof(payload_size); | ||
| static_assert( header_size == message_header_size, "invalid message_header_size" ); | ||
| size_t buffer_size = header_size + payload_size; |
brianjohnson5972
approved these changes
Feb 14, 2019
baegjae
added a commit
to baegjae/eos
that referenced
this pull request
May 28, 2019
hard to handle the logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
None
API Changes
None
Documentation Additions
None