This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add warning to --state-history-endpoint #6776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Feb 19, 2019
| @@ -512,7 +512,8 @@ void state_history_plugin::set_program_options(options_description& cli, options | |||
| options("trace-history", bpo::bool_switch()->default_value(false), "enable trace history"); | |||
| options("chain-state-history", bpo::bool_switch()->default_value(false), "enable chain state history"); | |||
| options("state-history-endpoint", bpo::value<string>()->default_value("0.0.0.0:8080"), | |||
| "the endpoint upon which to listen for incoming connections"); | |||
| "the endpoint upon which to listen for incoming connections. Caution: only expose this port to " | |||
| "your internal network."); | |||
There was a problem hiding this comment.
Should the provided default be 127.0.0.1:8080 ?
There was a problem hiding this comment.
It depends on if users normally run the fillers on the same or different machines
There was a problem hiding this comment.
Should you change the default value on line 514 to 127.0.0.1:8080 since that will be the normal case?
heifner
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The help message for
--state-history-endpointnow includes a warning to only expose this port to private networks.The default endpoint for the state history plugin has changed to
127.0.0.1:8080.Consensus Changes
API Changes
Documentation Additions