Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Build script: support new options #7095

Merged
merged 4 commits into from Apr 18, 2019
Merged

Conversation

mitza-oci
Copy link
Contributor

Change Description

Enhanced the build script with the ability to specify a prefix directory (instead of assuming HOME) and a pre-built Boost.
Cleaned up the usage message.
Moved commands that make changes on the filesystem later (after preliminary checks are done).
Removed unsupported -a "Avoid Compiling"

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

…ory (instead of assuming HOME) and a pre-built Boost.

Also cleaned up the usage message and wait to make changes on the filesystem until preliminary checks are done.
@spoonincode
Copy link
Contributor

Most of these changes look good but I'm concerned that the ability to set a custom prefix will mess up eosio_install.sh

…impacts display to user); remove unused vars
Copy link
Contributor

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried this on a centos7 image with
scripts/eosio_build.sh -p /eosroot
but failed with
/home/spoon/eos/scripts/../scripts/eosio_build_centos.sh: line 247: /home/spoon/bin/cmake: No such file or directory

looks like some more stuff needs to be modified

@mitza-oci
Copy link
Contributor Author

tried this on a centos7 image with
scripts/eosio_build.sh -p /eosroot
but failed with
/home/spoon/eos/scripts/../scripts/eosio_build_centos.sh: line 247: /home/spoon/bin/cmake: No such file or directory

Did it print Installing CMAKE...? Should it be using the distro's CMake?

@spoonincode spoonincode merged commit d8c0b85 into EOSIO:develop Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants