This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Avoid possibly lengthy destruction of wasm instances on shutdown #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the wasm_interface is destroyed, all unique_ptrs to the current instantiated modules are also destroyed. Unfortuately for some wasm runtimes -- wavm -- this incurs a lengthy garbage collection process for each module that is deleted. This can cause destruction of wasm_interface to take on the order of multiple minutes when there are thousands of instances! We need to violate the abstraction layer here and drop these instances on the floor during shutdown so the user isn't waiting minutes
heifner
suggested changes
Apr 22, 2019
heifner
approved these changes
Apr 22, 2019
arhag
approved these changes
Apr 24, 2019
heifner
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When the wasm_interface is destroyed, all unique_ptrs to the current instantiated modules are also destroyed. Unfortunately for some wasm runtimes -- wavm with #7176 -- this incurs a lengthy garbage collection process for each module that is deleted. This can cause destruction of wasm_interface to take on the order of multiple minutes when there are thousands of instances! We need to violate the abstraction layer here and drop these instances on the floor during shutdown so the user isn't waiting minutes
I am completely open to other approaches here
Consensus Changes
API Changes
Documentation Additions