Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Avoid possibly lengthy destruction of wasm instances on shutdown #7177

Merged
merged 3 commits into from
Apr 24, 2019

Commits on Apr 22, 2019

  1. Avoid destruction of wasm instances on shutdown

    When the wasm_interface is destroyed, all unique_ptrs to the current instantiated modules are also destroyed. Unfortuately for some wasm runtimes -- wavm -- this incurs a lengthy garbage collection process for each module that is deleted. This can cause destruction of wasm_interface to take on the order of multiple minutes when there are thousands of instances! We need to violate the abstraction layer here and drop these instances on the floor during shutdown so the user isn't waiting minutes
    spoonincode committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    4335a22 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Configuration menu
    Copy the full SHA
    3585b5c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b3b579 View commit details
    Browse the repository at this point in the history