Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

added sudo -E to installs for Ben on automation + zlib if fix #7297

Merged
merged 3 commits into from
May 8, 2019

Conversation

NorseGaud
Copy link
Contributor

  • Fixed if for zlib
  • Added sudo -E for proxies to work (Ben on Automation needs this)

@NorseGaud NorseGaud requested a review from heifner May 7, 2019 20:39
@NorseGaud
Copy link
Contributor Author

@heifner Sorry for the second PR for the same thing. I royally screwed up the previous branch and figured I'd just start off fresh to be safe.

@spoonincode
Copy link
Contributor

Is setting the proxy in yum's config file not workable?

@NorseGaud
Copy link
Contributor Author

NorseGaud commented May 8, 2019

@benbenben1010 could answer that, but I personally believe having to add the proxy settings to each and every distro (and remember they're set there & it's not just YUM that needs this) would be a lot more work.

@benbenben1010
Copy link
Contributor

The -E is nice because it allows us to use the same Dockerfile in the sandbox (which requires the proxy) and outside the sandbox (which doesn't) by conditionally passing in environment variables to the docker build command.

That being said, building in the sandbox has been de-prioritized, so for now, I don't have a strong opinion either way.

@NorseGaud NorseGaud merged commit e94ab69 into release/1.8.x May 8, 2019
@NorseGaud NorseGaud deleted the zlib-fix branch May 8, 2019 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants