This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Created "version-label" Integration Test #7354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Last week, we had an issue where the binaries attached to a 1.8 release contained a 1.7 version string.
This pull request introduces the "version-label" integration test, which compares the output of
nodes --versionto our CMake files to determine that the version string is what we expect it to be. This test will only run in Buildkite against tagged builds. If this test is not running in Buildkite or the build does not have a GitHub tag, this test immediately returnsEXIT_SUCCESS.Tested
See Also
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.