Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] BASE IMAGE Fixes #7532

Merged
merged 22 commits into from
Jun 26, 2019
Merged

[develop] BASE IMAGE Fixes #7532

merged 22 commits into from
Jun 26, 2019

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented Jun 25, 2019

The base images pipeline was failing for various reasons:
https://buildkite.com/EOSIO/eosio-base-images/builds/285

Ubuntu: build-essentials (or anything used for compiling) was missing pre-cmake/boost/clang, so they couldn't compile from source.
Centos7: devtoolset-8 fails to build clang8
For 1, I've added build-essentials pre dep install
For 2, I've moved back to devtoolset-7

Base Images Pipeline --
https://buildkite.com/EOSIO/eosio-base-images/builds/301

EOSIO Pipeline --
https://buildkite.com/EOSIO/eosio/builds/13461

@NorseGaud NorseGaud requested a review from arhag June 25, 2019 18:47
@NorseGaud
Copy link
Contributor Author

Pending new docker base layers; will take a few hours to generate them

Copy link
Contributor

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I only have two recommended changes on the messages printed.

scripts/eosio_build_centos.sh Outdated Show resolved Hide resolved
scripts/helpers/general.sh Outdated Show resolved Hide resolved
@NorseGaud NorseGaud merged commit ec79672 into develop Jun 26, 2019
@NorseGaud NorseGaud deleted the develop-cmake-fix branch June 26, 2019 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants