This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
unit test ensuring that OOB table init allowed on set code; fails on action #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action Out of bound table elements are accepted during setcode but then fail later when the wasm module is actually instantiated when an action is executed. This is arguably the correct behavior when viewed from the standpoint of the wasm spec. However, it's probably not what we intended -- OOB memory init is caught during setcode. Regardless, this goof isn't really a problem. But, this goof is now consensus. So add a unit test for this goofy behavior.
b1bart
suggested changes
Aug 8, 2019
b1bart
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Out of bound table elements are accepted during setcode but then fail later when the wasm module is actually instantiated when an action is executed. This is arguably the correct behavior when viewed from the standpoint of the wasm spec. However, it's probably not what we intended -- OOB memory init is caught during setcode.
Regardless, this goof isn't really a problem. But, this goof is now consensus. So add a unit test for this goofy behavior.
Consensus Changes
API Changes
Documentation Additions