This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
support unix socket HTTP server for nodeos #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Sep 22, 2019
| @@ -392,6 +392,10 @@ namespace eosio { | |||
| cfg.add_options() | |||
| ("unix-socket-path", bpo::value<string>()->default_value(current_http_plugin_defaults.default_unix_socket_path), | |||
| "The filename (relative to data-dir) to create a unix socket for HTTP RPC; set blank to disable."); | |||
| else | |||
There was a problem hiding this comment.
unfortunately I had to do the else here because default_value() balked at an empty string 🤷♂
heifner
approved these changes
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When unix socket support for the http plugin was initially added it was implicitly disabled for nodeos because it was only available to configure if the program activating http plugin had a default unix socket path set. (keosd had a default, nodeos doesn't)
Some users have requested the ability to use unix socket for nodeos because they have something in front of nodeos (like haproxy) and desire the, at least on paper, lower overhead of a unix socket.
This PR removes the check thus allowing any application using http plugin (like nodeos) to enable the unix socket by configuring it appropriately. It still is off by default for nodeos.
Enabling it for nodeos is as simple as a
unix-socket-path = nodeos.sockfor example. And to test you cancurl --unix-socket $EOSIO_DATA_DIR/nodeos.sock http://x/v1/chain/get_infoConsensus Changes
API Changes
Documentation Additions