This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add possibility to run .cicd scripts from different environments (2.0.x Backport) #8972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### With FORCE_LINUX=true, you can run the Docker version in `build.sh` an `package.sh` scripts When running the scripts from Mac OS X, it was always picking up the Darwin conditional paths in the script. `FORCE_LINUX=true` can be used on a Mac OS X environment to run the scripts. ### Fix shell expansion in `package.sh` In the packaging script, there is a Docker pre command that add executable bit permission on *.sh scripts in the `build/packages` folder. However, without the escaping, the shell expansion was performed in the `package.sh` script execution directly instead of being delayed so that the expansion is performed inside the `docker run` call! I suspect this worked in your CI system because execution of `package.sh` in performed in such way that filesystem layout of `package.sh` and filesystem layout of `docker run` were the same and as such, the expanded `chmod 755 file1.sh file2.sh` command was correctly working inside the container. The shell expansion via the `*` is now escaped which correctly delays the expansion until it's in the `docker run` execution environment. ### Conditional buildkite-agent upload Now, the upload task is performed only if BUILDKITE env is set to `true`, so it's possible to run the script without having to upload the actual package.
heifner
approved these changes
Apr 17, 2020
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Backport to
release/2.0.xbranch of PR #8865Consensus Changes
API Changes
Documentation Additions