Fixed shell expansion of chmod command within .cicd/packages.sh script

[maoueh]

Change Description

In the past, I had submitted some fixes to .cicd pipeline so it was usable in different environment (see #8972).

Some recent change (9986ee7) remove that. Here is a new fix that works with the new changes that have been made to the .cicd pipeline.

Tested this change locally on my workstation (Mac OS X) as well as in our CI system (CloudBuild so Linux host), both worked appropriately performing the shell expansion inside the Docker container and not in the host.

Ping @kj4ezj since you are the one who did the commit so just want to be sure it's all right.

I have a similar patch for master, just waiting for an heads-up to open a PR on master branch.

Change Type

• Documentation
• Stability bug fix
• Other

Testing Changes

• New Tests
• Existing Tests
• Test Framework
• CI System
• Other

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

[maoueh]

Here output when ran locally with .cicd/package.sh patched to use bash -xc (so it prints everything that will be executed inside the docker run ... bash invocation):

$ PLATFORM_TYPE=pinned IMAGE_TAG=ubuntu-18.04-pinned OS=ubuntu-18.04 PKGTYPE=deb MIRROR_REGISTRY=custom-repo FORCE_LINUX=true ./.cicd/package.sh
--- :evergreen_tree: Configuring Environment
--- :docker: Selecting Container
$ docker run --rm --init -v "$(pwd):/eos"  'custom-repo:eos-ubuntu-18.04-pinned-2126231de095fbc6d4fe2064c1cc11c7f6e99df2' bash -xc 'echo "+++ :package: Packaging EOSIO" && cd "/eos/build/packages" && chmod 755 './*.sh' && ./generate_package.sh "deb"'
+ echo '+++ :package: Packaging EOSIO'
+ cd /eos/build/packages
+++ :package: Packaging EOSIO
+ chmod 755 ./generate_bottle.sh ./generate_deb.sh ./generate_package.sh ./generate_rpm.sh ./generate_tarball.sh
+ ./generate_package.sh deb
Package: eosio
Version: 2.0.8
Section: devel
...