This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
sync from block vault during block production #9752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1bart
suggested changes
Dec 6, 2020
larryk85
reviewed
Dec 6, 2020
| try { | ||
| _impl->blockvault->sync(&id, *this); | ||
| } catch( fc::exception& er ) { | ||
| wlog("Attempting to resync from blockvault encountered ${details}; the node must restart to " |
There was a problem hiding this comment.
You missed:
line 326 dlog.
line 341 elog
Not sure if this was intentional.
huangminghuang
force-pushed
the
huangminghuang/bv-sync
branch
from
6022c9f
to
a406b85
Compare
b1bart
suggested changes
Dec 6, 2020
b1bart
approved these changes
Dec 7, 2020
# Conflicts: # tests/blockvault_tests.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR allows nodeos to sync with block vault when it doesn't receive the required block from peer logical producer node within 1 second.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions