This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix to prevent returning wrong authority string if this is a non-EOS prefix (e.g. TLOS) #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test and everything .. thank you .. I have been hearing about telos, so interesting. Hopefully we will get cross-chain functionality, that is doing to help everyone. I should change the prefix though to something neutral so it is fair to everyone out there. PUB I guess would be descriptive. I get this out soon. |
jcalfee
pushed a commit
that referenced
this pull request
Aug 22, 2018
|
Published eosjs@16.0.6 |
10gic
pushed a commit
to AAAChain/jssdk
that referenced
this pull request
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider merging this fix to prevent returning wrong authority string if this is a non-EOS prefix. Similar patches were merged and pushed to npm for related issues in eosjs-ecc, as confirmed in closed PRs EOSIO/eosjs-ecc#30 and EOSIO/eosjs-ecc#32
Can we get this merged and pushed to npm as soon as possible?